Fix friendly frame parsing bugs.

Fix friendly frame parsing bugs.

Fix bug parsing a friendly frame with spaces in the member name.
Fix bug parsing a friendly frame where the location is a data url.

BUG=
R=nweiz@google.com

Committed: https://github.com/dart-lang/stack_trace/commit/70329a4c72e37c3207ca165d8208d90e23568681

[Jacob, 2017-03-07 19:26:59]

jacobr@google.com changed reviewers:
+ nweiz@google.com

[Jacob, 2017-03-07 19:26:59]

Fix bug parsing a friendly frame with spaces in the member name.
Fix bug parsing a friendly frame where the location is a data url.

The first bug only impacts DDC.
The second bug impacts stack traces running vm tests as well.
For example, previously you would see:

 unparsed                               data:... 11:25                          
                          main


instead of

data:... 11:25                         main

[nweiz, 2017-03-07 21:27:28]

https://codereview.chromium.org/2739643004/diff/1/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/2739643004/diff/1/CHANGELOG.md#newcode3
CHANGELOG.md:3: * Fix bug parsing a friendly frame where the location is a data
url.
De-indent these and add newlines between them (basically, format them like the
other entries).

https://codereview.chromium.org/2739643004/diff/1/lib/src/frame.dart
File lib/src/frame.dart (right):

https://codereview.chromium.org/2739643004/diff/1/lib/src/frame.dart#newcode257
lib/src/frame.dart:257: ? new Uri.dataFromString('...')
Maybe just pass this an empty string. I think that better represents "we don't
know the data this contains".

https://codereview.chromium.org/2739643004/diff/1/test/frame_test.dart
File test/frame_test.dart (right):

https://codereview.chromium.org/2739643004/diff/1/test/frame_test.dart#newcod...
test/frame_test.dart:496: "foo/bar.dart 10:11    (anonymous function).dart.fn");
Wherever this "(anonymous function)" frame is coming from originally (V8
parsing?), it should be converted to "<fn>". We normalize the various
implementation-specific representations of anonymous functions to that.

[Jacob, 2017-03-07 23:27:21]

https://codereview.chromium.org/2739643004/diff/1/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/2739643004/diff/1/CHANGELOG.md#newcode3
CHANGELOG.md:3: * Fix bug parsing a friendly frame where the location is a data
url.
On 2017/03/07 21:27:28, nweiz wrote:
> De-indent these and add newlines between them (basically, format them like the
> other entries).

Done.

https://codereview.chromium.org/2739643004/diff/1/lib/src/frame.dart
File lib/src/frame.dart (right):

https://codereview.chromium.org/2739643004/diff/1/lib/src/frame.dart#newcode257
lib/src/frame.dart:257: ? new Uri.dataFromString('...')
On 2017/03/07 21:27:28, nweiz wrote:
> Maybe just pass this an empty string. I think that better represents "we don't
> know the data this contains".
Done.

https://codereview.chromium.org/2739643004/diff/1/test/frame_test.dart
File test/frame_test.dart (right):

https://codereview.chromium.org/2739643004/diff/1/test/frame_test.dart#newcod...
test/frame_test.dart:496: "foo/bar.dart 10:11    (anonymous function).dart.fn");
On 2017/03/07 21:27:28, nweiz wrote:
> Wherever this "(anonymous function)" frame is coming from originally (V8
> parsing?), it should be converted to "<fn>". We normalize the various
> implementation-specific representations of anonymous functions to that.

Ot isn't because V8 has tweaked the strings they use to describe anonymous
functions. In Chrome Beta and probably elsewhere you can now get the string
(anonymous function) in addition to the existing patterns Anonymous function and
<anonymous>.
I've added a test to verify that case is now handled consistently replacing
(anonymous function) with <fn>
I'd still like to keep this test as odds are some browser will tweak their names
for anonymous functions again breaking this code again.

I can change this test from 
(anonymous function) to (unexpected function name) or something if you want to
make it clear that real world friendly stack traces are not expected to have
spaces in their names.

[nweiz, 2017-03-07 23:44:32]

lgtm

https://codereview.chromium.org/2739643004/diff/1/test/frame_test.dart
File test/frame_test.dart (right):

https://codereview.chromium.org/2739643004/diff/1/test/frame_test.dart#newcod...
test/frame_test.dart:496: "foo/bar.dart 10:11    (anonymous function).dart.fn");
On 2017/03/07 23:27:20, Jacob wrote:
> On 2017/03/07 21:27:28, nweiz wrote:
> > Wherever this "(anonymous function)" frame is coming from originally (V8
> > parsing?), it should be converted to "<fn>". We normalize the various
> > implementation-specific representations of anonymous functions to that.
> 
> Ot isn't because V8 has tweaked the strings they use to describe anonymous
> functions. In Chrome Beta and probably elsewhere you can now get the string
> (anonymous function) in addition to the existing patterns Anonymous function
and
> <anonymous>.
> I've added a test to verify that case is now handled consistently replacing
> (anonymous function) with <fn>
> I'd still like to keep this test as odds are some browser will tweak their
names
> for anonymous functions again breaking this code again.

SGTM

> I can change this test from 
> (anonymous function) to (unexpected function name) or something if you want to
> make it clear that real world friendly stack traces are not expected to have
> spaces in their names.

Probably not necessary.

[Jacob, 2017-03-07 23:45:37]

Description was changed from

==========
Fix friendly frame parsing bugs.

Fix bug parsing a friendly frame with spaces in the member name.
Fix bug parsing a friendly frame where the location is a data url.

BUG=
==========

to

==========
Fix friendly frame parsing bugs.

Fix bug parsing a friendly frame with spaces in the member name.
Fix bug parsing a friendly frame where the location is a data url.

BUG=
R=nweiz@google.com

Committed:
https://github.com/dart-lang/stack_trace/commit/70329a4c72e37c3207ca165d8208d...
==========

[Jacob, 2017-03-07 23:45:38]

Committed patchset #3 (id:40001) manually as
70329a4c72e37c3207ca165d8208d90e23568681 (presubmit successful).