Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(9)

Issue 2739643004: Fix friendly frame parsing bugs. (Closed)

Created:
3 years, 9 months ago by Jacob
Modified:
3 years, 9 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix friendly frame parsing bugs. Fix bug parsing a friendly frame with spaces in the member name. Fix bug parsing a friendly frame where the location is a data url. BUG= R=nweiz@google.com Committed: https://github.com/dart-lang/stack_trace/commit/70329a4c72e37c3207ca165d8208d90e23568681

Patch Set 1 #

Total comments: 7

Patch Set 2 : Fix friendly frame parsing bugs. #

Patch Set 3 : Fix friendly frame parsing bugs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -6 lines) Patch
M CHANGELOG.md View 1 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/frame.dart View 1 3 chunks +10 lines, -4 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/frame_test.dart View 2 chunks +40 lines, -1 line 0 comments Download
M test/trace_test.dart View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jacob
Fix bug parsing a friendly frame with spaces in the member name. Fix bug parsing ...
3 years, 9 months ago (2017-03-07 19:26:59 UTC) #2
nweiz
https://codereview.chromium.org/2739643004/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/2739643004/diff/1/CHANGELOG.md#newcode3 CHANGELOG.md:3: * Fix bug parsing a friendly frame where the ...
3 years, 9 months ago (2017-03-07 21:27:28 UTC) #3
Jacob
https://codereview.chromium.org/2739643004/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/2739643004/diff/1/CHANGELOG.md#newcode3 CHANGELOG.md:3: * Fix bug parsing a friendly frame where the ...
3 years, 9 months ago (2017-03-07 23:27:21 UTC) #4
nweiz
lgtm https://codereview.chromium.org/2739643004/diff/1/test/frame_test.dart File test/frame_test.dart (right): https://codereview.chromium.org/2739643004/diff/1/test/frame_test.dart#newcode496 test/frame_test.dart:496: "foo/bar.dart 10:11 (anonymous function).dart.fn"); On 2017/03/07 23:27:20, Jacob ...
3 years, 9 months ago (2017-03-07 23:44:32 UTC) #5
Jacob
3 years, 9 months ago (2017-03-07 23:45:38 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
70329a4c72e37c3207ca165d8208d90e23568681 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698