Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: components/safe_browsing_db/safe_browsing_prefs.h

Issue 2739643003: Make Sber1/2 pref metrics into Nullable Booleans so we can track how often these prefs are unset. (Closed)
Patch Set: Split SawInterstitial pref/metric into SBER1/2 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/profiles/profile.cc ('k') | components/safe_browsing_db/safe_browsing_prefs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/safe_browsing_db/safe_browsing_prefs.h
diff --git a/components/safe_browsing_db/safe_browsing_prefs.h b/components/safe_browsing_db/safe_browsing_prefs.h
index da25461697ea0949598bce3a39b12f1fa675afdf..361f5ef0b545cd11b0fb573c89c35053123f2596 100644
--- a/components/safe_browsing_db/safe_browsing_prefs.h
+++ b/components/safe_browsing_db/safe_browsing_prefs.h
@@ -23,6 +23,14 @@ extern const char kSafeBrowsingScoutReportingEnabled[];
// affects which of SafeBrowsingExtendedReporting or SafeBrowsingScoutReporting
// is used.
extern const char kSafeBrowsingScoutGroupSelected[];
+
+// Boolean indicating whether the user has ever seen a security interstitial
+// containing the legacy Extended Reporting opt-in.
+extern const char kSafeBrowsingSawInterstitialSber1[];
Mike Lerman 2017/03/08 20:08:36 Can you make these variable names for descriptive?
lpz 2017/03/09 17:58:01 Done.
+
+// Boolean indicating whether the user has ever seen a security interstitial
+// containing the new Scout opt-in.
+extern const char kSafeBrowsingSawInterstitialSber2[];
}
namespace safe_browsing {
« no previous file with comments | « chrome/browser/profiles/profile.cc ('k') | components/safe_browsing_db/safe_browsing_prefs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698