Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 2739643002: VM: Remove ZoneCompileType class. (Closed)

Created:
3 years, 9 months ago by Vyacheslav Egorov (Google)
Modified:
3 years, 9 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Remove ZoneCompileType class. This auxiliary wrapper was introduced originally to work-around an assertion in ZoneAllocated destructor which was preventing us from using descendants of ZoneAllocated as value objects. That assertion was removed some time ago which means ZoneCompileType is not needed anymore and CompileType can become ZoneAllocated instead. R=fschneider@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/da5cd4197a3f2bd4730de36b72475b34378f9dba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -27 lines) Patch
M runtime/vm/flow_graph_type_propagator.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/intermediate_language.h View 5 chunks +4 lines, -22 lines 0 comments Download
M runtime/vm/intrinsifier.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Vyacheslav Egorov (Google)
3 years, 9 months ago (2017-03-07 14:14:00 UTC) #1
Florian Schneider
lgtm
3 years, 9 months ago (2017-03-07 16:04:52 UTC) #2
Vyacheslav Egorov (Google)
3 years, 9 months ago (2017-03-07 16:29:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
da5cd4197a3f2bd4730de36b72475b34378f9dba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698