Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2739623002: VM: [Kernel, Precompiler] Improve Function and Field hashes for objects originating from Kernel. (Closed)

Created:
3 years, 9 months ago by Vyacheslav Egorov (Google)
Modified:
3 years, 9 months ago
Reviewers:
erikcorry, rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: [Kernel, Precompiler] Improve Function and Field hashes for objects originating from Kernel. Currently Fasta does not assign any position information to these objects so we had a very bad hash for them. BUG= R=erikcorry@google.com Committed: https://github.com/dart-lang/sdk/commit/64940df644eec0197e7ef846efa61230074d6bec

Patch Set 1 #

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M runtime/vm/precompiler.h View 1 3 chunks +21 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Vyacheslav Egorov (Google)
3 years, 9 months ago (2017-03-07 11:54:52 UTC) #2
Vyacheslav Egorov (Google)
PTAL
3 years, 9 months ago (2017-03-07 11:55:22 UTC) #5
erikcorry
lgtm
3 years, 9 months ago (2017-03-07 11:59:18 UTC) #6
Vyacheslav Egorov (Google)
Committed patchset #2 (id:20001) manually as 64940df644eec0197e7ef846efa61230074d6bec (presubmit successful).
3 years, 9 months ago (2017-03-07 12:25:52 UTC) #8
rmacnak
3 years, 9 months ago (2017-03-07 17:27:05 UTC) #9
Message was sent while issue was closed.
lgtm

IIRC, there's an outstanding task to load kernel directly into the Dart heap
instead of the C heap. Might be worth making a note that this hash won't be
valid then.

Powered by Google App Engine
This is Rietveld 408576698