content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellTestCommon.java - Issue 2739603003: Add TestRules for content shell test and refactor test bases

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellTestCommon.java

Issue 2739603003: Add TestRules for content shell test and refactor test bases (Closed)

Patch Set: Address +boliu's comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellTestBase.java ('k') | tools/android/eclipse/.classpath » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellTestCommon.java

diff --git a/content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellTestCommon.java b/content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellTestCommon.java

index 263723fb1ed6ed790372310d99d29597d5cca563..1259221bff4d849df0f97c01c62b50640476ef3c 100644

--- a/content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellTestCommon.java

+++ b/content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellTestCommon.java

@@ -191,5 +191,9 @@ public final class ContentShellTestCommon {

T launchActivityWithIntentForTestCommon(Intent t);

T getActivityForTestCommon();

void runOnUiThreadForTestCommon(Runnable runnable) throws Throwable;

+ ContentViewCore getContentViewCoreForTestCommon();

+ ContentShellActivity launchContentShellWithUrlForTestCommon(String url);

+ WebContents getWebContentsForTestCommon();

+ void waitForActiveShellToBeDoneLoadingForTestCommon();

}