Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1602)

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBasicsTest.java

Issue 2739603003: Add TestRules for content shell test and refactor test bases (Closed)
Patch Set: Address +boliu's comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBasicsTest.java
diff --git a/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBasicsTest.java b/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBasicsTest.java
index a26160ab6ec7cd6499150c45646132c25691375c..1ea2e883524840a5226f9f59918c96bbe3e8df7e 100644
--- a/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBasicsTest.java
+++ b/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBasicsTest.java
@@ -13,6 +13,7 @@ import junit.framework.Assert;
import org.chromium.base.annotations.SuppressFBWarnings;
import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.Feature;
+import org.chromium.content.browser.JavaBridgeTestCommon.Controller;
import org.chromium.content.browser.test.util.TestCallbackHelperContainer;
import org.chromium.content_public.browser.LoadUrlParams;
@@ -179,7 +180,7 @@ public class JavaBridgeBasicsTest extends JavaBridgeTestBase {
@Feature({"AndroidWebView", "Android-JavaBridge"})
public void testRemoveObjectNotAdded() throws Throwable {
TestCallbackHelperContainer.OnPageFinishedHelper onPageFinishedHelper =
- mTestCallbackHelperContainer.getOnPageFinishedHelper();
+ getTestCallBackHelperContainer().getOnPageFinishedHelper();
int currentCallCount = onPageFinishedHelper.getCallCount();
runTestOnUiThread(new Runnable() {
@Override
@@ -863,7 +864,7 @@ public class JavaBridgeBasicsTest extends JavaBridgeTestBase {
// Manually inject the Test object, making sure to use the
// ContentViewCore#addJavascriptInterface, not the possibly unsafe version.
TestCallbackHelperContainer.OnPageFinishedHelper onPageFinishedHelper =
- mTestCallbackHelperContainer.getOnPageFinishedHelper();
+ getTestCallBackHelperContainer().getOnPageFinishedHelper();
int currentCallCount = onPageFinishedHelper.getCallCount();
runTestOnUiThread(new Runnable() {
@Override

Powered by Google App Engine
This is Rietveld 408576698