Add TestRules for content shell test and refactor test bases

content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellTestCommon.java

Index: content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellTestCommon.java
diff --git a/content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellTestCommon.java b/content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellTestCommon.java
index 263723fb1ed6ed790372310d99d29597d5cca563..1259221bff4d849df0f97c01c62b50640476ef3c 100644
--- a/content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellTestCommon.java
+++ b/content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellTestCommon.java
@@ -191,5 +191,9 @@ public final class ContentShellTestCommon {
         T launchActivityWithIntentForTestCommon(Intent t);
         T getActivityForTestCommon();
         void runOnUiThreadForTestCommon(Runnable runnable) throws Throwable;
+        ContentViewCore getContentViewCoreForTestCommon();

[boliu, 2017/03/08 21:40:18]

this assumes test has only one CVC? that seems too specific for all test cases
and can probably be structured differently

[the real yoland, 2017/03/08 22:53:53]

One alternative is to create another interface (e.g. TestCommonCallback2),
declare these methods, and implement them in TestRule/TestBase that needs them.
but that will end up having both ContentDetectionTestBase/TestRule and
JavaBridgeTestBase/TestRule implement both TestCommonCallback and
TestCommonCallback2. And the worst part is in TestCommon class, it will have two
callback object that are essentially the same object calling 2 different set of
APIs

Or maybe I can name this more specifically or avoid the complication. Because
what this is doing is just exposing an API that is previously inherited to a
now-composed object.

[boliu, 2017/03/08 23:03:05]

Actually, content tests don't generally use multiple CVCs, so this might be ok.

But if this was a long term thing, and if we really wanted to fix it, it would
be passing CVC directly into the calls that need it.

[the real yoland, 2017/03/08 23:52:45]

ack

+        ContentShellActivity launchContentShellWithUrlForTestCommon(String url);
+        WebContents getWebContentsForTestCommon();

[boliu, 2017/03/08 21:40:18]

ditto

+        void waitForActiveShellToBeDoneLoadingForTestCommon();

[boliu, 2017/03/08 21:40:18]

ditto

     }
 }