Rename Document::widgetForElement to frameViewBaseForElement

third_party/WebKit/Source/core/dom/Node.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All
  * rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
  * (http://www.torchmobile.com/)
  *
@@ skipping 74 matching lines @@
 #include "core/events/WheelEvent.h"
 #include "core/frame/EventHandlerRegistry.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/LocalDOMWindow.h"
 #include "core/frame/LocalFrame.h"
 #include "core/html/HTMLDialogElement.h"
 #include "core/html/HTMLFrameOwnerElement.h"
 #include "core/html/HTMLSlotElement.h"
 #include "core/input/EventHandler.h"
 #include "core/layout/LayoutBox.h"
+#include "core/layout/LayoutPart.h"
 #include "core/page/ContextMenuController.h"
 #include "core/page/Page.h"
 #include "core/svg/SVGElement.h"
 #include "core/svg/graphics/SVGImage.h"
 #include "platform/EventDispatchForbiddenScope.h"
 #include "platform/InstanceCounters.h"
 #include "platform/RuntimeEnabledFeatures.h"
 #include "platform/instrumentation/tracing/TraceEvent.h"
 #include "platform/instrumentation/tracing/TracedValue.h"
 #include "wtf/HashSet.h"
@@ skipping 482 matching lines @@
                                                : nullptr;
 }
 
 LayoutBoxModelObject* Node::layoutBoxModelObject() const {
   LayoutObject* layoutObject = this->layoutObject();
   return layoutObject && layoutObject->isBoxModelObject()
              ? toLayoutBoxModelObject(layoutObject)
              : nullptr;
 }
 
+FrameViewBase* Node::frameViewBase() const {
+  LayoutObject* layoutObject = this->layoutObject();
+  return layoutObject && layoutObject->isLayoutPart()

[sashab, 2017/03/10 04:30:13]

I actually don't know if this is easier to read :( The early exit was simple and
matches the rest of the codebase... Can we leave it that way? :)

[joelhockey, 2017/03/10 04:37:53]

I wrote it to match the surrounding, related code.  See the 2 methods above it.

[sashab, 2017/03/10 04:47:22]

Oh, so you did, sorry about that :)

+             ? toLayoutPart(layoutObject)->frameViewBase()
+             : nullptr;
+}
+
 LayoutRect Node::boundingBox() const {
   if (layoutObject())
     return LayoutRect(layoutObject()->absoluteBoundingBoxRect());
   return LayoutRect();
 }
 
 #ifndef NDEBUG
 inline static ShadowRoot* oldestShadowRootFor(const Node* node) {
   if (!node->isElementNode())
     return nullptr;
@@ skipping 1960 matching lines @@
   if (node) {
     std::stringstream stream;
     node->printNodePathTo(stream);
     LOG(INFO) << stream.str();
   } else {
     LOG(INFO) << "Cannot showNodePath for <null>";
   }
 }
 
 #endif