Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Side by Side Diff: chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc

Issue 2739553005: Moves maintaining root_window_for_new_windows_ to Shell (Closed)
Patch Set: remove ash:: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/common/shelf/shelf_view.h" 5 #include "ash/common/shelf/shelf_view.h"
6 #include "ash/common/shelf/wm_shelf.h" 6 #include "ash/common/shelf/wm_shelf.h"
7 #include "ash/common/wm_window.h" 7 #include "ash/common/wm_window.h"
8 #include "ash/shell.h" 8 #include "ash/shell.h"
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/location.h" 10 #include "base/location.h"
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 KeepAliveRestartOption::DISABLED); 95 KeepAliveRestartOption::DISABLED);
96 96
97 aura::Window::Windows root_windows = ash::Shell::GetAllRootWindows(); 97 aura::Window::Windows root_windows = ash::Shell::GetAllRootWindows();
98 98
99 BrowserList* browser_list = BrowserList::GetInstance(); 99 BrowserList* browser_list = BrowserList::GetInstance();
100 100
101 EXPECT_EQ(1u, browser_list->size()); 101 EXPECT_EQ(1u, browser_list->size());
102 // Close the browser window so that clicking icon will create a new window. 102 // Close the browser window so that clicking icon will create a new window.
103 CloseBrowser(browser_list->get(0)); 103 CloseBrowser(browser_list->get(0));
104 EXPECT_EQ(0u, browser_list->size()); 104 EXPECT_EQ(0u, browser_list->size());
105 EXPECT_EQ(root_windows[0], ash::Shell::GetTargetRootWindow()); 105 EXPECT_EQ(root_windows[0], ash::Shell::GetRootWindowForNewWindows());
106 106
107 OpenBrowserUsingShelfOnRootWindow(root_windows[1]); 107 OpenBrowserUsingShelfOnRootWindow(root_windows[1]);
108 108
109 // A new browser must be created on 2nd display. 109 // A new browser must be created on 2nd display.
110 EXPECT_EQ(1u, browser_list->size()); 110 EXPECT_EQ(1u, browser_list->size());
111 EXPECT_EQ(root_windows[1], 111 EXPECT_EQ(root_windows[1],
112 browser_list->get(0)->window()->GetNativeWindow()->GetRootWindow()); 112 browser_list->get(0)->window()->GetNativeWindow()->GetRootWindow());
113 EXPECT_EQ(root_windows[1], ash::Shell::GetTargetRootWindow()); 113 EXPECT_EQ(root_windows[1], ash::Shell::GetRootWindowForNewWindows());
114 114
115 // Close the browser window so that clicking icon will create a new window. 115 // Close the browser window so that clicking icon will create a new window.
116 CloseBrowser(browser_list->get(0)); 116 CloseBrowser(browser_list->get(0));
117 EXPECT_EQ(0u, browser_list->size()); 117 EXPECT_EQ(0u, browser_list->size());
118 118
119 OpenBrowserUsingShelfOnRootWindow(root_windows[0]); 119 OpenBrowserUsingShelfOnRootWindow(root_windows[0]);
120 120
121 // A new browser must be created on 1st display. 121 // A new browser must be created on 1st display.
122 EXPECT_EQ(1u, browser_list->size()); 122 EXPECT_EQ(1u, browser_list->size());
123 EXPECT_EQ(root_windows[0], 123 EXPECT_EQ(root_windows[0],
124 browser_list->get(0)->window()->GetNativeWindow()->GetRootWindow()); 124 browser_list->get(0)->window()->GetNativeWindow()->GetRootWindow());
125 EXPECT_EQ(root_windows[0], ash::Shell::GetTargetRootWindow()); 125 EXPECT_EQ(root_windows[0], ash::Shell::GetRootWindowForNewWindows());
126 } 126 }
127 127
128 namespace { 128 namespace {
129 129
130 class WindowSizerContextMenuTest : public WindowSizerTest { 130 class WindowSizerContextMenuTest : public WindowSizerTest {
131 public: 131 public:
132 WindowSizerContextMenuTest() {} 132 WindowSizerContextMenuTest() {}
133 ~WindowSizerContextMenuTest() override {} 133 ~WindowSizerContextMenuTest() override {}
134 134
135 static void Step1(gfx::Point release_point) { 135 static void Step1(gfx::Point release_point) {
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
178 ScopedKeepAlive test_keep_alive(KeepAliveOrigin::BROWSER_PROCESS_CHROMEOS, 178 ScopedKeepAlive test_keep_alive(KeepAliveOrigin::BROWSER_PROCESS_CHROMEOS,
179 KeepAliveRestartOption::DISABLED); 179 KeepAliveRestartOption::DISABLED);
180 180
181 views::MenuController::TurnOffMenuSelectionHoldForTest(); 181 views::MenuController::TurnOffMenuSelectionHoldForTest();
182 182
183 aura::Window::Windows root_windows = ash::Shell::GetAllRootWindows(); 183 aura::Window::Windows root_windows = ash::Shell::GetAllRootWindows();
184 184
185 BrowserList* browser_list = BrowserList::GetInstance(); 185 BrowserList* browser_list = BrowserList::GetInstance();
186 186
187 ASSERT_EQ(1u, browser_list->size()); 187 ASSERT_EQ(1u, browser_list->size());
188 EXPECT_EQ(root_windows[0], ash::Shell::GetTargetRootWindow()); 188 EXPECT_EQ(root_windows[0], ash::Shell::GetRootWindowForNewWindows());
189 CloseBrowser(browser_list->get(0)); 189 CloseBrowser(browser_list->get(0));
190 190
191 OpenBrowserUsingContextMenuOnRootWindow(root_windows[1]); 191 OpenBrowserUsingContextMenuOnRootWindow(root_windows[1]);
192 192
193 // A new browser must be created on 2nd display. 193 // A new browser must be created on 2nd display.
194 ASSERT_EQ(1u, browser_list->size()); 194 ASSERT_EQ(1u, browser_list->size());
195 EXPECT_EQ(root_windows[1], 195 EXPECT_EQ(root_windows[1],
196 browser_list->get(0)->window()->GetNativeWindow()->GetRootWindow()); 196 browser_list->get(0)->window()->GetNativeWindow()->GetRootWindow());
197 EXPECT_EQ(root_windows[1], ash::Shell::GetTargetRootWindow()); 197 EXPECT_EQ(root_windows[1], ash::Shell::GetRootWindowForNewWindows());
198 198
199 CloseBrowser(browser_list->get(0)); 199 CloseBrowser(browser_list->get(0));
200 OpenBrowserUsingContextMenuOnRootWindow(root_windows[0]); 200 OpenBrowserUsingContextMenuOnRootWindow(root_windows[0]);
201 201
202 // Next new browser must be created on 1st display. 202 // Next new browser must be created on 1st display.
203 ASSERT_EQ(1u, browser_list->size()); 203 ASSERT_EQ(1u, browser_list->size());
204 EXPECT_EQ(root_windows[0], 204 EXPECT_EQ(root_windows[0],
205 browser_list->get(0)->window()->GetNativeWindow()->GetRootWindow()); 205 browser_list->get(0)->window()->GetNativeWindow()->GetRootWindow());
206 EXPECT_EQ(root_windows[0], ash::Shell::GetTargetRootWindow()); 206 EXPECT_EQ(root_windows[0], ash::Shell::GetRootWindowForNewWindows());
207 } 207 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/window_sizer/window_sizer.cc ('k') | chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698