Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

Issue 2739553003: Make ComputedStyleBase abstract. (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl
diff --git a/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl b/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl
index 7aab85d717cc68071045a77f528a9568aa14875a..f8366ecdfc5a583b4b31b004816daca03195abb8 100644
--- a/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl
+++ b/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl
@@ -24,19 +24,6 @@ namespace blink {
// in ComputedStyle.h.
class CORE_EXPORT ComputedStyleBase {
public:
- ALWAYS_INLINE ComputedStyleBase() :
- {% for field in fields %}
- {{field.name}}(static_cast<unsigned>({{field.default_value}})){{print_if(not loop.last, ',')}}
- {% endfor %}
- {}
- ~ComputedStyleBase() {}
-
- ALWAYS_INLINE ComputedStyleBase(const ComputedStyleBase& o) :
- {% for field in fields %}
- {{field.name}}(o.{{field.name}}){{print_if(not loop.last, ',')}}
- {% endfor %}
- {}
-
inline bool independentInheritedEqual(const ComputedStyleBase& o) const {
return (
{% for field in fields if field.is_property and field.is_inherited and field.is_independent %}
@@ -89,6 +76,20 @@ class CORE_EXPORT ComputedStyleBase {
{% endfor %}
protected:
+ ALWAYS_INLINE ComputedStyleBase() :
+ {% for field in fields %}
+ {{field.name}}(static_cast<unsigned>({{field.default_value}})){{print_if(not loop.last, ',')}}
+ {% endfor %}
+ {}
+
+ ~ComputedStyleBase() = default;
sashab 2017/03/16 23:55:31 I like this, but can we add a comment here like: /
+
+ ALWAYS_INLINE ComputedStyleBase(const ComputedStyleBase& o) :
+ {% for field in fields %}
+ {{field.name}}(o.{{field.name}}){{print_if(not loop.last, ',')}}
+ {% endfor %}
+ {}
+
// Storage.
{% for field in fields %}
unsigned {{field.name}} : {{field.size}}; // {{field.type_name}}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698