Ash devtools: Add support for changing visibility.

ash/common/devtools/ash_devtools_css_agent.cc

Index: ash/common/devtools/ash_devtools_css_agent.cc
diff --git a/ash/common/devtools/ash_devtools_css_agent.cc b/ash/common/devtools/ash_devtools_css_agent.cc
index 390dea0c8e2d976d02d3ec83c84055ac6b7d4b42..584ec32bb12ac6a0b1b1742d3249af5786ace00c 100644
--- a/ash/common/devtools/ash_devtools_css_agent.cc
+++ b/ash/common/devtools/ash_devtools_css_agent.cc
@@ -18,6 +18,7 @@ const char kHeight[] = "height";
 const char kWidth[] = "width";
 const char kX[] = "x";
 const char kY[] = "y";
+const char kVisibility[] = "visibility";
 
 std::unique_ptr<CSS::SourceRange> BuildDefaultSourceRange() {
   // These tell the frontend where in the stylesheet a certain style
@@ -41,47 +42,32 @@ std::unique_ptr<CSS::CSSProperty> BuildCSSProperty(const std::string& name,
       .build();
 }
 
-std::unique_ptr<Array<CSS::CSSProperty>> BuildBoundsCSSPropertyArray(
-    const gfx::Rect& bounds) {
+std::unique_ptr<Array<CSS::CSSProperty>> BuildCSSPropertyArray(
+    const gfx::Rect& bounds,
+    const bool visible) {
   auto cssProperties = Array<CSS::CSSProperty>::create();
   cssProperties->addItem(BuildCSSProperty(kHeight, bounds.height()));
   cssProperties->addItem(BuildCSSProperty(kWidth, bounds.width()));
   cssProperties->addItem(BuildCSSProperty(kX, bounds.x()));
   cssProperties->addItem(BuildCSSProperty(kY, bounds.y()));
+  cssProperties->addItem(BuildCSSProperty(kVisibility, visible));
   return cssProperties;
 }
 
 std::unique_ptr<CSS::CSSStyle> BuildCSSStyle(int node_id,
-                                             const gfx::Rect& bounds) {
+                                             const gfx::Rect& bounds,
+                                             const bool visible) {
   return CSS::CSSStyle::create()
       .setRange(BuildDefaultSourceRange())
       .setStyleSheetId(base::IntToString(node_id))
-      .setCssProperties(BuildBoundsCSSPropertyArray(bounds))
+      .setCssProperties(BuildCSSPropertyArray(bounds, visible))
       .setShorthandEntries(Array<std::string>::create())
       .build();
 }
 
-Response ParseBounds(const std::string& style_text, gfx::Rect& bounds) {
-  std::vector<std::string> tokens = base::SplitString(
-      style_text, ":;", base::TRIM_WHITESPACE, base::SPLIT_WANT_NONEMPTY);
-  for (size_t i = 0; i < tokens.size() - 1; i += 2) {
-    const std::string& property = tokens.at(i);
-    int value;
-    if (!base::StringToInt(tokens.at(i + 1), &value))
-      return Response::Error("Unable to parse value for property=" + property);
-
-    if (property == kHeight)
-      bounds.set_height(std::max(0, value));
-    else if (property == kWidth)
-      bounds.set_width(std::max(0, value));
-    else if (property == kX)
-      bounds.set_x(value);
-    else if (property == kY)
-      bounds.set_y(value);
-    else
-      return Response::Error("Unsupported property=" + property);
-  }
-  return Response::OK();
+ui::devtools::protocol::Response NodeNotFoundError(int node_id) {
+  return ui::devtools::protocol::Response::Error(
+      "Node with id=" + std::to_string(node_id) + " not found");
 }
 
 }  // namespace
@@ -110,10 +96,8 @@ ui::devtools::protocol::Response AshDevToolsCSSAgent::getMatchedStylesForNode(
     ui::devtools::protocol::Maybe<ui::devtools::protocol::CSS::CSSStyle>*
         inline_style) {
   *inline_style = GetStylesForNode(node_id);
-  if (!inline_style) {
-    return ui::devtools::protocol::Response::Error(
-        "Node with that id not found");
-  }
+  if (!inline_style)
+    NodeNotFoundError(node_id);

[sadrul, 2017/03/09 18:11:33]

return NodeNotFoundError(node_id);

[thanhph, 2017/03/09 18:50:17]

oops, thanks!

   return ui::devtools::protocol::Response::OK();
 }
 
@@ -134,23 +118,20 @@ ui::devtools::protocol::Response AshDevToolsCSSAgent::setStyleTexts(
       return ui::devtools::protocol::Response::Error("Invalid node id");
 
     gfx::Rect updated_bounds;
-    if (!GetBoundsForNodeId(node_id, &updated_bounds)) {
-      return ui::devtools::protocol::Response::Error(
-          "No node found with that id");
-    }
+    bool visible;
+    if (!GetPropertiesForNodeId(node_id, &updated_bounds, &visible))
+      NodeNotFoundError(node_id);

[sadrul, 2017/03/09 18:11:33]

return

(applies same comment applies to code below)

[thanhph, 2017/03/09 18:50:17]

Done.

 
     ui::devtools::protocol::Response response(
-        ParseBounds(edit->getText(), updated_bounds));
+        ParseProperties(edit->getText(), &updated_bounds, &visible));
     if (!response.isSuccess())
       return response;
 
-    updated_styles->addItem(BuildCSSStyle(node_id, updated_bounds));
-    if (!UpdateBounds(node_id, updated_bounds)) {
-      return ui::devtools::protocol::Response::Error(
-          "No node found with that id");
-    }
-  }
+    updated_styles->addItem(BuildCSSStyle(node_id, updated_bounds, visible));
 
+    if (!SetPropertiesForNodeId(node_id, updated_bounds, visible))
+      NodeNotFoundError(node_id);
+  }
   *result = std::move(updated_styles);
   return ui::devtools::protocol::Response::OK();
 }
@@ -170,8 +151,10 @@ void AshDevToolsCSSAgent::OnViewBoundsChanged(views::View* view) {
 std::unique_ptr<ui::devtools::protocol::CSS::CSSStyle>
 AshDevToolsCSSAgent::GetStylesForNode(int node_id) {
   gfx::Rect bounds;
-  return GetBoundsForNodeId(node_id, &bounds) ? BuildCSSStyle(node_id, bounds)
-                                              : nullptr;
+  bool visible;
+  return GetPropertiesForNodeId(node_id, &bounds, &visible)
+             ? BuildCSSStyle(node_id, bounds, visible)
+             : nullptr;
 }
 
 void AshDevToolsCSSAgent::InvalidateStyleSheet(int node_id) {
@@ -179,49 +162,91 @@ void AshDevToolsCSSAgent::InvalidateStyleSheet(int node_id) {
   frontend()->styleSheetChanged(base::IntToString(node_id));
 }
 
-bool AshDevToolsCSSAgent::GetBoundsForNodeId(int node_id, gfx::Rect* bounds) {
+bool AshDevToolsCSSAgent::GetPropertiesForNodeId(int node_id,
+                                                 gfx::Rect* bounds,
+                                                 bool* visible) {
   WmWindow* window = dom_agent_->GetWindowFromNodeId(node_id);
   if (window) {
     *bounds = window->GetBounds();
+    *visible = window->IsVisible();
     return true;
   }
-
   views::Widget* widget = dom_agent_->GetWidgetFromNodeId(node_id);
   if (widget) {
     *bounds = widget->GetRestoredBounds();
+    *visible = widget->IsVisible();
     return true;
   }
-
   views::View* view = dom_agent_->GetViewFromNodeId(node_id);
   if (view) {
     *bounds = view->bounds();
+    *visible = view->visible();
     return true;
   }
-
   return false;
 }
 
-bool AshDevToolsCSSAgent::UpdateBounds(int node_id, const gfx::Rect& bounds) {
+bool AshDevToolsCSSAgent::SetPropertiesForNodeId(int node_id,
+                                                 const gfx::Rect& bounds,
+                                                 const bool visible) {
   WmWindow* window = dom_agent_->GetWindowFromNodeId(node_id);
   if (window) {
     window->SetBounds(bounds);
+    if (visible != window->IsVisible()) {
+      if (visible)
+        window->Show();
+      else
+        window->Hide();
+    }
     return true;
   }
-
   views::Widget* widget = dom_agent_->GetWidgetFromNodeId(node_id);
   if (widget) {
     widget->SetBounds(bounds);
+    if (visible != widget->IsVisible()) {
+      if (visible)
+        widget->Show();
+      else
+        widget->Hide();
+    }
     return true;
   }
-
   views::View* view = dom_agent_->GetViewFromNodeId(node_id);
   if (view) {
     view->SetBoundsRect(bounds);
+    if (visible != view->visible())
+      view->SetVisible(visible);
     return true;
   }
-
   return false;
 }
 
+Response AshDevToolsCSSAgent::ParseProperties(const std::string& style_text,

[sadrul, 2017/03/09 18:11:33]

Is there a reason this function can't remain as an independent function in the
anonymous namespace above? (this doesn't actually seem to use |dom_agent_| or
anything?)

[thanhph, 2017/03/09 18:50:17]

My bad, I was using |dom_agent_| here to reduce code duplication before we
discussed the new interface. I move ParseProperties() back to anon namespace.

+                                              gfx::Rect* bounds,
+                                              bool* visible) {
+  std::vector<std::string> tokens = base::SplitString(
+      style_text, ":;", base::TRIM_WHITESPACE, base::SPLIT_WANT_NONEMPTY);
+  for (size_t i = 0; i < tokens.size() - 1; i += 2) {
+    const std::string& property = tokens.at(i);
+    int value;
+    if (!base::StringToInt(tokens.at(i + 1), &value))

[sadrul, 2017/03/09 18:11:33]

Is visibility sent as an int too?

[thanhph, 2017/03/09 18:50:17]

Yes, 0 for non-visible and 1 is visible. We could also parse the word "true" or
"false" but this is probably more costly.

+      return Response::Error("Unable to parse value for property=" + property);
+
+    if (property == kHeight)
+      bounds->set_height(std::max(0, value));
+    else if (property == kWidth)
+      bounds->set_width(std::max(0, value));
+    else if (property == kX)
+      bounds->set_x(value);
+    else if (property == kY)
+      bounds->set_y(value);
+    else if (property == kVisibility)
+      *visible = std::max(0, value) == 1;
+    else
+      return Response::Error("Unsupported property=" + property);
+  }
+  return Response::OK();
+}
+
 }  // namespace devtools
 }  // namespace ash