Settings reset prompt: add UMA metrics reporting.

chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_controller.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_controller.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/location.h"
 #include "base/logging.h"
+#include "base/metrics/histogram_macros.h"
+#include "base/metrics/user_metrics.h"
+#include "base/metrics/user_metrics_action.h"
 #include "base/time/time.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_config.h"
 #include "chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_model.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/scoped_tabbed_browser_displayer.h"
 #include "chrome/grit/chromium_strings.h"
 #include "chrome/grit/generated_resources.h"
 #include "components/url_formatter/elide_url.h"
 #include "content/public/browser/browser_thread.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "url/gurl.h"
 
 namespace safe_browsing {
 
 namespace {
 
+enum DialogState {

[robertshield, 2017/03/07 07:43:19]

Add a comment mentioning this is used for UMA reporting.

[alito, 2017/03/07 16:23:29]

Done.

+  DIALOG_STATE_SHOWN = 1,
+  DIALOG_STATE_ACCEPTED = 2,
+  DIALOG_STATE_DECLINED = 3,
+  DIALOG_STATE_MAX = 4,
+};
+
 base::string16 FormatUrlForDisplay(const GURL& url) {
   return url_formatter::FormatUrlForSecurityDisplay(
       url, url_formatter::SchemeDisplay::OMIT_HTTP_AND_HTTPS);
 }
 
 bool ResetSearchEnabled(const SettingsResetPromptModel& model) {
   return model.default_search_reset_state() ==
          SettingsResetPromptModel::RESET_REQUIRED;
 }
 
 bool ResetStartupUrlsEnabled(const SettingsResetPromptModel& model) {
   return model.startup_urls_reset_state() ==
          SettingsResetPromptModel::RESET_REQUIRED;
 }
 
 bool ResetHomepageEnabled(const SettingsResetPromptModel& model) {
   return model.homepage_reset_state() ==
          SettingsResetPromptModel::RESET_REQUIRED;
 }
 
 // Function that is passed the newly created |SettingsResetPromptModel| object
 // as a result of a call to |MaybeShowSettingsResetPrompt()| below. Will display
 // the settings reset prompt if required by the model and there is at least one
 // non-incognito browser available for the corresponding profile.
 void OnModelCreated(std::unique_ptr<SettingsResetPromptModel> model) {
+  if (model)

[csharp, 2017/03/07 14:39:40]

nit: I wonder if this part would look a bit clearer as:
if (!model)
  return

model->ReportUmaMetrics();

if (!model->ShouldPromptForReset())
  return

(Same number of ifs, but I think a bit clearer)

[alito, 2017/03/07 16:23:29]

Done.

+    model->ReportUmaMetrics();
+
   if (!model || !model->ShouldPromptForReset())
     return;
 
   Profile* profile = model->profile();
 
   // Ensure that there is at least one non-incognito browser open for the
   // profile before attempting to show the dialog.
   if (!chrome::FindTabbedBrowser(profile, /*match_original_profiles=*/false))
     return;
 
@@ skipping 64 matching lines @@
   DCHECK(!main_text_.empty());
   return main_text_;
 }
 
 gfx::Range SettingsResetPromptController::GetMainTextUrlRange() const {
   return main_text_url_range_;
 }
 
 void SettingsResetPromptController::DialogShown() {
   model_->DialogShown();
+  time_dialog_shown_ = base::Time::Now();
+  base::RecordAction(base::UserMetricsAction("SettingsResetPrompt_Shown"));
+  UMA_HISTOGRAM_ENUMERATION("SettingsResetPrompt.DialogState",
+                            DIALOG_STATE_SHOWN, DIALOG_STATE_MAX);
 }
 
 void SettingsResetPromptController::Accept() {
+  DCHECK(!time_dialog_shown_.is_null());
+  base::RecordAction(base::UserMetricsAction("SettingsResetPrompt_Accepted"));
+  UMA_HISTOGRAM_LONG_TIMES_100("SettingsResetPrompt.TimeUntilAccepted",
+                               base::Time::Now() - time_dialog_shown_);
+  UMA_HISTOGRAM_ENUMERATION("SettingsResetPrompt.DialogState",
+                            DIALOG_STATE_ACCEPTED, DIALOG_STATE_MAX);
   model_->PerformReset(
       base::Bind(&SettingsResetPromptController::OnInteractionDone,
                  base::Unretained(this)));
 }
 
 void SettingsResetPromptController::Cancel() {
+  DCHECK(!time_dialog_shown_.is_null());
+  base::RecordAction(base::UserMetricsAction("SettingsResetPrompt_Declined"));
+  UMA_HISTOGRAM_LONG_TIMES_100("SettingsResetPrompt.TimeUntilDeclined",
+                               base::Time::Now() - time_dialog_shown_);
+  UMA_HISTOGRAM_ENUMERATION("SettingsResetPrompt.DialogState",
+                            DIALOG_STATE_DECLINED, DIALOG_STATE_MAX);
   OnInteractionDone();
 }
 
 void SettingsResetPromptController::InitMainText() {
   DCHECK(main_text_.empty());
 
   // Get the URL string to be displayed in the dialog message.
   base::string16 url_string;
   if (ResetSearchEnabled(*model_)) {
     url_string = FormatUrlForDisplay(model_->default_search());
@@ skipping 38 matching lines @@
         url_string, &offset);
   } else {
     NOTREACHED();
   }
 
   main_text_url_range_.set_start(offset);
   main_text_url_range_.set_end(offset + url_string.length());
 }
 
 void SettingsResetPromptController::OnInteractionDone() {
-  // TODO(alito): Add metrics reporting here.
   delete this;
 }
 
 void MaybeShowSettingsResetPromptWithDelay() {
   std::unique_ptr<SettingsResetPromptConfig> config =
       SettingsResetPromptConfig::Create();
   if (!config)
     return;
 
   base::TimeDelta delay = config->delay_before_prompt();
   content::BrowserThread::PostDelayedTask(
       content::BrowserThread::UI, FROM_HERE,
       base::Bind(MaybeShowSettingsResetPrompt, base::Passed(&config)), delay);
 }
 
 }  // namespace safe_browsing