Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1533)

Unified Diff: cc/output/overlay_unittest.cc

Issue 2739473002: cc: Reject non-opaque fullscreen overlay candidates. (Closed)
Patch Set: Rebase on master. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/overlay_strategy_fullscreen.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/overlay_unittest.cc
diff --git a/cc/output/overlay_unittest.cc b/cc/output/overlay_unittest.cc
index 52a7d030eca61b133155a070fc5de17233193ade..2e1dffa3a707a0c04499657387790fecf5dadfe4 100644
--- a/cc/output/overlay_unittest.cc
+++ b/cc/output/overlay_unittest.cc
@@ -507,6 +507,29 @@ TEST_F(FullscreenOverlayTest, SuccessfulOverlay) {
EXPECT_EQ(original_resource_id, candidate_list.front().resource_id);
}
+TEST_F(FullscreenOverlayTest, AlphaFail) {
+ std::unique_ptr<RenderPass> pass = CreateRenderPass();
+ TextureDrawQuad* original_quad = CreateFullscreenCandidateQuad(
+ resource_provider_.get(), pass->shared_quad_state_list.back(),
+ pass.get());
+ original_quad->opaque_rect = gfx::Rect(0, 0, 0, 0);
+
+ // Check for potential candidates.
+ OverlayCandidateList candidate_list;
+ RenderPassFilterList render_pass_filters;
+ RenderPassFilterList render_pass_background_filters;
+ overlay_processor_->ProcessForOverlays(
+ resource_provider_.get(), pass.get(), render_pass_filters,
+ render_pass_background_filters, &candidate_list, nullptr, nullptr,
+ &damage_rect_, &content_bounds_);
+
+ RenderPass* main_pass = pass.get();
+ // Check that all the quads are gone.
+ EXPECT_EQ(1U, main_pass->quad_list.size());
+ // Check that we have only one overlay.
+ EXPECT_EQ(0U, candidate_list.size());
+}
+
TEST_F(FullscreenOverlayTest, ResourceSizeInPixelsFail) {
std::unique_ptr<RenderPass> pass = CreateRenderPass();
TextureDrawQuad* original_quad = CreateFullscreenCandidateQuad(
« no previous file with comments | « cc/output/overlay_strategy_fullscreen.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698