Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: components/autofill/content/renderer/password_generation_agent.h

Issue 2739373002: Password generation logging (Closed)
Patch Set: compilation fix Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/autofill/content/renderer/password_generation_agent.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/content/renderer/password_generation_agent.h
diff --git a/components/autofill/content/renderer/password_generation_agent.h b/components/autofill/content/renderer/password_generation_agent.h
index 694c5fc990cf2e67a99d9e9873dd481e074a2520..c7cb5fb27d990cb6de676a7348dd776dea2fc571 100644
--- a/components/autofill/content/renderer/password_generation_agent.h
+++ b/components/autofill/content/renderer/password_generation_agent.h
@@ -16,6 +16,7 @@
#include "base/memory/linked_ptr.h"
#include "components/autofill/content/common/autofill_agent.mojom.h"
#include "components/autofill/content/common/autofill_driver.mojom.h"
+#include "components/autofill/content/renderer/renderer_save_password_progress_logger.h"
#include "content/public/renderer/render_frame_observer.h"
#include "mojo/public/cpp/bindings/binding.h"
#include "third_party/WebKit/public/web/WebInputElement.h"
@@ -66,7 +67,7 @@ class PasswordGenerationAgent : public content::RenderFrameObserver,
protected:
// Returns true if the document for |render_frame()| is one that we should
// consider analyzing. Virtual so that it can be overriden during testing.
- virtual bool ShouldAnalyzeDocument() const;
+ virtual bool ShouldAnalyzeDocument();
// Use to force enable during testing.
void set_enabled(bool enabled) { enabled_ = enabled; }
@@ -118,6 +119,12 @@ class PasswordGenerationAgent : public content::RenderFrameObserver,
void RunFormClassifierAndSaveVote(const blink::WebFormElement& web_form,
const PasswordForm& form);
+ void LogMessage(autofill::SavePasswordProgressLogger::StringID message_id);
+ void LogBoolean(autofill::SavePasswordProgressLogger::StringID message_id,
+ bool truth_value);
+ void LogNumber(autofill::SavePasswordProgressLogger::StringID message_id,
+ int number);
+
// Creates a password form to presave a generated password. It copies behavior
// of CreatePasswordFormFromWebForm/FromUnownedInputElements, but takes
// |password_value| from |generation_element_| and empties |username_value|.
« no previous file with comments | « no previous file | components/autofill/content/renderer/password_generation_agent.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698