Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 2739343003: Implement correct label scope. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Parent may be null. #

Patch Set 3 : Add method to lookup local labels. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -13 lines) Patch
M pkg/front_end/lib/src/fasta/builder/scope.dart View 1 2 2 chunks +17 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 2 6 chunks +9 lines, -12 lines 0 comments Download
M tests/co19/co19-kernel.status View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
ahe
3 years, 9 months ago (2017-03-10 13:11:09 UTC) #2
karlklose
LGTM
3 years, 9 months ago (2017-03-10 13:16:44 UTC) #3
ahe
3 years, 9 months ago (2017-03-10 14:19:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
c8d49070dfb4a6481f2fd6a473e78ab970b7bcd2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698