Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1411)

Issue 273933002: Allow exclusive touchmove slop regions in the TouchEventQueue (Closed)

Created:
6 years, 7 months ago by jdduke (slow)
Modified:
6 years, 7 months ago
Reviewers:
Rick Byers
CC:
chromium-reviews, jam, jdduke+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Allow exclusive touchmove slop regions in the TouchEventQueue Aura's current slop region is boundary exclusive, whereas Android's is boundary inclusive. With the unified GR, both platforms will use a boundary inclusive slop region, but until such time the TouchEventQueue should support either model. Allow this distinction via a configurable TouchEventQueue::Config parameter. BUG=354763 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269496

Patch Set 1 #

Patch Set 2 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -10 lines) Patch
M content/browser/renderer_host/input/input_router_config_helper.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_event_queue.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/touch_event_queue.cc View 5 chunks +17 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_event_queue_unittest.cc View 1 11 chunks +85 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jdduke (slow)
Rick, PTAL. This might be overkill, but testing is just easier without the #ifdef sauce. ...
6 years, 7 months ago (2014-05-08 22:32:07 UTC) #1
Rick Byers
This LGTM, thanks! Yeah I think the DCHECK is good - a little more aggressive ...
6 years, 7 months ago (2014-05-09 00:13:17 UTC) #2
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 7 months ago (2014-05-09 00:57:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/273933002/20001
6 years, 7 months ago (2014-05-09 01:05:06 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 02:47:29 UTC) #5
Message was sent while issue was closed.
Change committed as 269496

Powered by Google App Engine
This is Rietveld 408576698