Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: content/browser/frame_host/navigation_request.cc

Issue 2739323003: DevTools protocol interception, blocking & modification of requests (Closed)
Patch Set: Add missing expects plus tweak test output of Network.interceptedRedirect for clarity Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_request.cc
diff --git a/content/browser/frame_host/navigation_request.cc b/content/browser/frame_host/navigation_request.cc
index a5a193160646054bdf9751aaf94b7c100b7092ed..42e0aa6e653410f86c58b14cb06b9913a4369edb 100644
--- a/content/browser/frame_host/navigation_request.cc
+++ b/content/browser/frame_host/navigation_request.cc
@@ -150,14 +150,9 @@ void AddAdditionalRequestHeaders(net::HttpRequestHeaders* headers,
? GetContentClient()->GetUserAgent()
: user_agent_override);
- // Check whether DevTools wants to override user agent for this request
- // after setting the default user agent.
- std::string devtools_user_agent =
- RenderFrameDevToolsAgentHost::UserAgentOverride(frame_tree_node);
- if (!devtools_user_agent.empty()) {
- headers->SetHeader(net::HttpRequestHeaders::kUserAgent,
- devtools_user_agent);
- }
+ // Let DevTools modify the headers (e.g. UserAgent) if required.
+ RenderFrameDevToolsAgentHost::ModifyRequestHeadersIfNeeded(frame_tree_node,
+ headers);
// Tack an 'Upgrade-Insecure-Requests' header to outgoing navigational
// requests, as described in

Powered by Google App Engine
This is Rietveld 408576698