Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Unified Diff: net/quic/core/quic_server_session_base_test.cc

Issue 2739313002: Remove multipath_enabled from quic_config and quic_connection. No functional change expected. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_packet_creator.h ('k') | net/quic/test_tools/quic_connection_peer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_server_session_base_test.cc
diff --git a/net/quic/core/quic_server_session_base_test.cc b/net/quic/core/quic_server_session_base_test.cc
index 34c6affc13b18507111c36d4853da881f6ada7fd..76735525a5fcb8722825e5dcabb6ad132a4c150d 100644
--- a/net/quic/core/quic_server_session_base_test.cc
+++ b/net/quic/core/quic_server_session_base_test.cc
@@ -409,8 +409,6 @@ TEST_P(QuicServerSessionBaseTest, BandwidthEstimates) {
// and we don't have any other data to write.
// Client has sent kBWRE connection option to trigger bandwidth resumption.
- // Disable this flag because if connection uses multipath sent packet manager,
- // static_cast here does not work.
QuicTagVector copt;
copt.push_back(kBWRE);
QuicConfigPeer::SetReceivedConnectionOptions(session_->config(), copt);
@@ -613,8 +611,8 @@ TEST_P(StreamMemberLifetimeTest, Basic) {
chlo.SetVector(kCOPT, QuicTagVector{kSREJ});
std::vector<QuicVersion> packet_version_list = {version};
std::unique_ptr<QuicEncryptedPacket> packet(ConstructEncryptedPacket(
- 1, true, false, false, 1,
- chlo.GetSerialized().AsStringPiece().as_string(),
+ 1, true, false, 1,
+ string(chlo.GetSerialized().AsStringPiece().as_string()),
PACKET_8BYTE_CONNECTION_ID, PACKET_6BYTE_PACKET_NUMBER,
&packet_version_list));
@@ -625,7 +623,7 @@ TEST_P(StreamMemberLifetimeTest, Basic) {
// Set the current packet
QuicConnectionPeer::SetCurrentPacket(session_->connection(),
- packet->AsStringPiece());
+ packet->AsStringPiece().as_string());
// Yes, this is horrible. But it's the easiest way to trigger the behavior we
// need to exercise.
« no previous file with comments | « net/quic/core/quic_packet_creator.h ('k') | net/quic/test_tools/quic_connection_peer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698