Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 27393002: Revert "Add a flag for enabling/disabling the new accelerated scrolling path" (Closed)

Created:
7 years, 2 months ago by Ian Vollick
Modified:
7 years, 2 months ago
Reviewers:
CC:
chromium-reviews, nkostylev+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Revert "Add a flag for enabling/disabling the new accelerated scrolling path" This reverts commit 429530bcff087403123cecafedbd93022fb74746. > Add a flag for enabling/disabling the new accelerated scrolling path > > We now have two accelerated scrolling paths. One accelerates scrolling whenever > it's safe to promote the overflow scrolling div to a stacking container / > containing block and not break stacking or clipping. > > The new path, the 'universal' path, enables accelerated scrolling in those cases > where the old path would not opt-in. > > Eventually, we'd like to eliminate the old path, but this will require layer > squashing (the new path can result in many composited layers that ought to be > combined -- i.e., a 'layer explosion'). Until these paths are mature, we need to > be able to enable and disable them both, so we have two separate sets of flags. > > Once we've eliminated the old path, we can replace both with > --[enable/disable]-accelerated-overflow-scroll (and eventually get rid of both > sets of flags). > > BUG=None > > Review URL: https://codereview.chromium.org/26809004 TBR=jamser@chromium.org BUG=307486 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228743

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -58 lines) Patch
M build/ios/grit_whitelist.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M content/public/common/content_switches.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/common/content_switches.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 chunks +0 lines, -16 lines 0 comments Download
M webkit/common/webpreferences.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/common/webpreferences.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Ian Vollick
7 years, 2 months ago (2013-10-15 19:48:30 UTC) #1
Message was sent while issue was closed.
Committed patchset #2 manually as r228743 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698