Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1079)

Issue 27392002: Remove SkColorTable from SkFlattenable hierarchy. (Closed)

Created:
7 years, 2 months ago by mtklein
Modified:
7 years, 2 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com, sugoi
Visibility:
Public.

Description

Remove SkColorTable from SkFlattenable hierarchy. BUG= Committed: http://code.google.com/p/skia/source/detail?r=11791

Patch Set 1 #

Patch Set 2 : reupload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -11 lines) Patch
M include/core/SkColorTable.h View 3 chunks +3 lines, -6 lines 0 comments Download
M src/core/SkColorTable.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkMallocPixelRef.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ports/SkGlobalInitialization_default.cpp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mtklein
out/Debug/bench_pictures isn't crashing, so can probably just roll through with this.
7 years, 2 months ago (2013-10-15 19:38:09 UTC) #1
mtklein
CC +sugoi
7 years, 2 months ago (2013-10-15 19:49:30 UTC) #2
reed1
awesome and clear -- lgtm
7 years, 2 months ago (2013-10-15 20:04:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/27392002/4001
7 years, 2 months ago (2013-10-15 20:05:41 UTC) #4
commit-bot: I haz the power
7 years, 2 months ago (2013-10-15 20:36:19 UTC) #5
Message was sent while issue was closed.
Change committed as 11791

Powered by Google App Engine
This is Rietveld 408576698