chrome/test/data/extensions/web_request_blocking/manifest.json - Issue 2739193004: Check for already existing entry when adding to SiteProcessMap.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/web_request_blocking/manifest.json

Issue 2739193004: Check for already existing entry when adding to SiteProcessMap. (Closed)

Patch Set: Fix. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 {

	2 "name": "webRequest Blocking",

	3 "version": "1.0",

	4 "manifest_version": 2,

	5 "description": "Tests navigation to a page blocked by webRequest API.",

	6 "permissions": ["webRequest", "webRequestBlocking", "tabs", "<all_urls>"],
	Devlin 2017/03/11 01:52:18 is tabs needed? is tabs needed? nasko 2017/03/13 17:22:03 Yes, it was used by tabs.create API call made in t Show quoted text On 2017/03/11 01:52:18, Devlin wrote: > is tabs needed? Yes, it was used by tabs.create API call made in the test. I've removed it after fixing the test. Devlin 2017/03/13 19:19:56 Fun fact: tabs.create doesn't require the tabs per Show quoted text On 2017/03/13 17:22:03, nasko (slow) wrote: > On 2017/03/11 01:52:18, Devlin wrote: > > is tabs needed? > > Yes, it was used by tabs.create API call made in the test. I've removed it after > fixing the test. Fun fact: tabs.create doesn't require the tabs permission.
	7 "web_accessible_resources": [ "blocked.html" ]

	8 }

OLD	NEW