Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: components/sync_sessions/favicon_cache.cc

Issue 2739173002: Always select best favicon bitmap (Closed)
Patch Set: WIP. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync_sessions/favicon_cache.cc
diff --git a/components/sync_sessions/favicon_cache.cc b/components/sync_sessions/favicon_cache.cc
index dff0ae06ccafdc6ca8919f0c1be5da98afbc7409..574eaedc1b4f5389d04c10a437477b049667db3c 100644
--- a/components/sync_sessions/favicon_cache.cc
+++ b/components/sync_sessions/favicon_cache.cc
@@ -433,12 +433,9 @@ void FaviconCache::OnPageFaviconUpdated(const GURL& page_url) {
return;
}
- // TODO(zea): This appears to only fetch one favicon (best match based on
- // desired_size_in_dip). Figure out a way to fetch all favicons we support.
- // See crbug.com/181068.
base::CancelableTaskTracker::TaskId id =
favicon_service_->GetFaviconForPageURL(
- page_url, SupportedFaviconTypes(), kMaxFaviconResolution,
+ page_url, SupportedFaviconTypes(), {kMaxFaviconResolution},
base::Bind(&FaviconCache::OnFaviconDataAvailable,
weak_ptr_factory_.GetWeakPtr(), page_url),
&cancelable_task_tracker_);

Powered by Google App Engine
This is Rietveld 408576698