Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: components/favicon/core/test/mock_favicon_service.h

Issue 2739173002: Always select best favicon bitmap (Closed)
Patch Set: WIP. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/favicon/core/test/mock_favicon_service.h
diff --git a/components/favicon/core/test/mock_favicon_service.h b/components/favicon/core/test/mock_favicon_service.h
index 376a266a12b3277a0592b78e247883803146006a..b7447e3037d04ea48158717b67fb7f070fa4d8ce 100644
--- a/components/favicon/core/test/mock_favicon_service.h
+++ b/components/favicon/core/test/mock_favicon_service.h
@@ -46,7 +46,7 @@ class MockFaviconService : public FaviconService {
base::CancelableTaskTracker::TaskId(
const GURL& icon_url,
favicon_base::IconType icon_type,
- int desired_size_in_dip,
+ const std::vector<int>& desired_sizes_in_pixel,
const favicon_base::FaviconResultsCallback& callback,
base::CancelableTaskTracker* tracker));
MOCK_METHOD3(GetFaviconImageForPageURL,
@@ -72,7 +72,7 @@ class MockFaviconService : public FaviconService {
base::CancelableTaskTracker::TaskId(
const GURL& page_url,
int icon_types,
- int desired_size_in_dip,
+ const std::vector<int>& desired_sizes_in_pixel,
const favicon_base::FaviconResultsCallback& callback,
base::CancelableTaskTracker* tracker));
MOCK_METHOD6(UpdateFaviconMappingsAndFetch,
@@ -80,7 +80,7 @@ class MockFaviconService : public FaviconService {
const GURL& page_url,
const std::vector<GURL>& icon_urls,
int icon_types,
- int desired_size_in_dip,
+ const std::vector<int>& desired_sizes_in_pixel,
const favicon_base::FaviconResultsCallback& callback,
base::CancelableTaskTracker* tracker));
MOCK_METHOD3(GetLargestRawFaviconForID,

Powered by Google App Engine
This is Rietveld 408576698