Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Side by Side Diff: components/favicon/core/favicon_service_impl.h

Issue 2739173002: Always select best favicon bitmap (Closed)
Patch Set: Updated. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_FAVICON_CORE_FAVICON_SERVICE_IMPL_H_ 5 #ifndef COMPONENTS_FAVICON_CORE_FAVICON_SERVICE_IMPL_H_
6 #define COMPONENTS_FAVICON_CORE_FAVICON_SERVICE_IMPL_H_ 6 #define COMPONENTS_FAVICON_CORE_FAVICON_SERVICE_IMPL_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 base::CancelableTaskTracker* tracker) override; 47 base::CancelableTaskTracker* tracker) override;
48 base::CancelableTaskTracker::TaskId GetRawFavicon( 48 base::CancelableTaskTracker::TaskId GetRawFavicon(
49 const GURL& icon_url, 49 const GURL& icon_url,
50 favicon_base::IconType icon_type, 50 favicon_base::IconType icon_type,
51 int desired_size_in_pixel, 51 int desired_size_in_pixel,
52 const favicon_base::FaviconRawBitmapCallback& callback, 52 const favicon_base::FaviconRawBitmapCallback& callback,
53 base::CancelableTaskTracker* tracker) override; 53 base::CancelableTaskTracker* tracker) override;
54 base::CancelableTaskTracker::TaskId GetFavicon( 54 base::CancelableTaskTracker::TaskId GetFavicon(
55 const GURL& icon_url, 55 const GURL& icon_url,
56 favicon_base::IconType icon_type, 56 favicon_base::IconType icon_type,
57 int desired_size_in_dip, 57 const std::vector<int>& desired_sizes_in_pixel,
58 const favicon_base::FaviconResultsCallback& callback, 58 const favicon_base::FaviconResultsCallback& callback,
59 base::CancelableTaskTracker* tracker) override; 59 base::CancelableTaskTracker* tracker) override;
60 base::CancelableTaskTracker::TaskId GetFaviconImageForPageURL( 60 base::CancelableTaskTracker::TaskId GetFaviconImageForPageURL(
61 const GURL& page_url, 61 const GURL& page_url,
62 const favicon_base::FaviconImageCallback& callback, 62 const favicon_base::FaviconImageCallback& callback,
63 base::CancelableTaskTracker* tracker) override; 63 base::CancelableTaskTracker* tracker) override;
64 base::CancelableTaskTracker::TaskId GetRawFaviconForPageURL( 64 base::CancelableTaskTracker::TaskId GetRawFaviconForPageURL(
65 const GURL& page_url, 65 const GURL& page_url,
66 int icon_types, 66 int icon_types,
67 int desired_size_in_pixel, 67 int desired_size_in_pixel,
68 const favicon_base::FaviconRawBitmapCallback& callback, 68 const favicon_base::FaviconRawBitmapCallback& callback,
69 base::CancelableTaskTracker* tracker) override; 69 base::CancelableTaskTracker* tracker) override;
70 base::CancelableTaskTracker::TaskId GetLargestRawFaviconForPageURL( 70 base::CancelableTaskTracker::TaskId GetLargestRawFaviconForPageURL(
71 const GURL& page_url, 71 const GURL& page_url,
72 const std::vector<int>& icon_types, 72 const std::vector<int>& icon_types,
73 int minimum_size_in_pixels, 73 int minimum_size_in_pixels,
74 const favicon_base::FaviconRawBitmapCallback& callback, 74 const favicon_base::FaviconRawBitmapCallback& callback,
75 base::CancelableTaskTracker* tracker) override; 75 base::CancelableTaskTracker* tracker) override;
76 base::CancelableTaskTracker::TaskId GetFaviconForPageURL( 76 base::CancelableTaskTracker::TaskId GetFaviconForPageURL(
77 const GURL& page_url, 77 const GURL& page_url,
78 int icon_types, 78 int icon_types,
79 int desired_size_in_dip, 79 const std::vector<int>& desired_sizes_in_pixel,
80 const favicon_base::FaviconResultsCallback& callback, 80 const favicon_base::FaviconResultsCallback& callback,
81 base::CancelableTaskTracker* tracker) override; 81 base::CancelableTaskTracker* tracker) override;
82 base::CancelableTaskTracker::TaskId UpdateFaviconMappingsAndFetch( 82 base::CancelableTaskTracker::TaskId UpdateFaviconMappingsAndFetch(
83 const GURL& page_url, 83 const GURL& page_url,
84 const std::vector<GURL>& icon_urls, 84 const std::vector<GURL>& icon_urls,
85 int icon_types, 85 int icon_types,
86 int desired_size_in_dip, 86 const std::vector<int>& desired_sizes_in_pixel,
87 const favicon_base::FaviconResultsCallback& callback, 87 const favicon_base::FaviconResultsCallback& callback,
88 base::CancelableTaskTracker* tracker) override; 88 base::CancelableTaskTracker* tracker) override;
89 base::CancelableTaskTracker::TaskId GetLargestRawFaviconForID( 89 base::CancelableTaskTracker::TaskId GetLargestRawFaviconForID(
90 favicon_base::FaviconID favicon_id, 90 favicon_base::FaviconID favicon_id,
91 const favicon_base::FaviconRawBitmapCallback& callback, 91 const favicon_base::FaviconRawBitmapCallback& callback,
92 base::CancelableTaskTracker* tracker) override; 92 base::CancelableTaskTracker* tracker) override;
93 void SetFaviconOutOfDateForPage(const GURL& page_url) override; 93 void SetFaviconOutOfDateForPage(const GURL& page_url) override;
94 void SetImportedFavicons( 94 void SetImportedFavicons(
95 const favicon_base::FaviconUsageDataList& favicon_usage) override; 95 const favicon_base::FaviconUsageDataList& favicon_usage) override;
96 void MergeFavicon(const GURL& page_url, 96 void MergeFavicon(const GURL& page_url,
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 base::hash_set<MissingFaviconURLHash> missing_favicon_urls_; 141 base::hash_set<MissingFaviconURLHash> missing_favicon_urls_;
142 std::unique_ptr<FaviconClient> favicon_client_; 142 std::unique_ptr<FaviconClient> favicon_client_;
143 history::HistoryService* history_service_; 143 history::HistoryService* history_service_;
144 144
145 DISALLOW_COPY_AND_ASSIGN(FaviconServiceImpl); 145 DISALLOW_COPY_AND_ASSIGN(FaviconServiceImpl);
146 }; 146 };
147 147
148 } // namespace favicon 148 } // namespace favicon
149 149
150 #endif // COMPONENTS_FAVICON_CORE_FAVICON_SERVICE_IMPL_H_ 150 #endif // COMPONENTS_FAVICON_CORE_FAVICON_SERVICE_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698