Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: net/quic/core/quic_transmission_info.h

Issue 2739053004: Remove static_assert for QuicTransmissionInfo size (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_QUIC_CORE_QUIC_TRANSMISSION_INFO_H_ 5 #ifndef NET_QUIC_CORE_QUIC_TRANSMISSION_INFO_H_
6 #define NET_QUIC_CORE_QUIC_TRANSMISSION_INFO_H_ 6 #define NET_QUIC_CORE_QUIC_TRANSMISSION_INFO_H_
7 7
8 #include <list> 8 #include <list>
9 9
10 #include "net/quic/core/frames/quic_frame.h" 10 #include "net/quic/core/frames/quic_frame.h"
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 // Non-zero if the packet needs padding if it's retransmitted. 51 // Non-zero if the packet needs padding if it's retransmitted.
52 int16_t num_padding_bytes; 52 int16_t num_padding_bytes;
53 // Stores the packet number of the next retransmission of this packet. 53 // Stores the packet number of the next retransmission of this packet.
54 // Zero if the packet has not been retransmitted. 54 // Zero if the packet has not been retransmitted.
55 QuicPacketNumber retransmission; 55 QuicPacketNumber retransmission;
56 // Non-empty if there is a listener for this packet. 56 // Non-empty if there is a listener for this packet.
57 std::list<AckListenerWrapper> ack_listeners; 57 std::list<AckListenerWrapper> ack_listeners;
58 // The largest_acked in the ack frame, if the packet contains an ack. 58 // The largest_acked in the ack frame, if the packet contains an ack.
59 QuicPacketNumber largest_acked; 59 QuicPacketNumber largest_acked;
60 }; 60 };
61 // TODO(ianswett): Add static_assert when size of this struct is reduced below
62 // 64 bytes.
63 // NOTE(vlovich): Existing static_assert removed because padding differences on
64 // 64-bit iOS resulted in an 88-byte struct that is greater than the 84-byte
65 // limit on other platforms. Removing per ianswett's request.
61 66
62 } // namespace net 67 } // namespace net
63 68
64 #endif // NET_QUIC_CORE_QUIC_TRANSMISSION_INFO_H_ 69 #endif // NET_QUIC_CORE_QUIC_TRANSMISSION_INFO_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698