Moving previews code from components/ to chrome/

components/previews/core/previews_experiments.cc

Index: components/previews/core/previews_experiments.cc
diff --git a/components/previews/core/previews_experiments.cc b/components/previews/core/previews_experiments.cc
index 77b973a2da62fdec35f3d677bf22d50c40105690..62a31840ff87c459434d221171f97c452be2cfd1 100644
--- a/components/previews/core/previews_experiments.cc
+++ b/components/previews/core/previews_experiments.cc
@@ -189,6 +189,19 @@ net::EffectiveConnectionType EffectiveConnectionTypeThreshold() {
   return effective_connection_type;
 }
 
+bool IsOfflinePreviewsEnabled() {
+  return ClientSidePreviewsParamValue(kOfflinePagesSlowNetwork) ==

[tbansal1, 2017/03/10 21:14:53]

Can you add comments on what this is exactly checking for.

May be change the function name to
IsOfflinePreviewsEnabledForSlowNetworks()

[RyanSturm, 2017/03/10 22:06:29]

Done.
Ack.

+         kExperimentEnabled;
+}
+
+int OfflinePreviewsVersion() {
+  int version;
+  if (!base::StringToInt(ClientSidePreviewsParamValue(kVersion), &version)) {

[tbansal1, 2017/03/10 21:14:53]

skip parens.

[RyanSturm, 2017/03/10 22:06:29]

Done.

+    version = 0;
+  }
+  return version;
+}
+
 }  // namespace params
 
 bool IsIncludedInClientSidePreviewsExperimentsFieldTrial() {
@@ -200,47 +213,6 @@ bool IsIncludedInClientSidePreviewsExperimentsFieldTrial() {
       kEnabled, base::CompareCase::SENSITIVE);
 }
 
-bool IsPreviewsTypeEnabled(PreviewsType type) {
-  switch (type) {
-    case PreviewsType::OFFLINE:
-      return ClientSidePreviewsParamValue(kOfflinePagesSlowNetwork) ==
-             kExperimentEnabled;
-    default:
-      NOTREACHED();
-      return false;
-  }
-}
-
-int GetPreviewsTypeVersion(PreviewsType type) {
-  int version = 0;  // default
-  switch (type) {
-    case PreviewsType::OFFLINE:
-      base::StringToInt(ClientSidePreviewsParamValue(kVersion), &version);
-      return version;
-    // List remaining enum cases vs. default to catch when new one is added.
-    case PreviewsType::NONE:
-      break;
-    case PreviewsType::LAST:
-      break;
-  }
-  NOTREACHED();
-  return -1;
-}
-
-std::unique_ptr<PreviewsTypeList> GetEnabledPreviews() {
-  std::unique_ptr<PreviewsTypeList> enabled_previews(new PreviewsTypeList());
-
-  // Loop across all previews types (relies on sequential enum values).
-  for (int i = static_cast<int>(PreviewsType::NONE) + 1;
-       i < static_cast<int>(PreviewsType::LAST); ++i) {
-    PreviewsType type = static_cast<PreviewsType>(i);
-    if (IsPreviewsTypeEnabled(type)) {
-      enabled_previews->push_back({type, GetPreviewsTypeVersion(type)});
-    }
-  }
-  return enabled_previews;
-}
-
 bool EnableOfflinePreviewsForTesting() {
   std::map<std::string, std::string> params;
   params[kOfflinePagesSlowNetwork] = kExperimentEnabled;