Moving previews code from components/ to chrome/

components/previews/core/previews_io_data_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/previews/core/previews_io_data.h"
 
 #include <map>
 #include <memory>
 #include <string>
 
@@ skipping 19 matching lines @@
 #include "net/nqe/network_quality_estimator_test_util.h"
 #include "net/url_request/url_request.h"
 #include "net/url_request/url_request_test_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
 
 namespace previews {
 
 namespace {
 
+bool CheckOfflineFieldTrial(PreviewsType type) {
+  return previews::params::IsOfflinePreviewsEnabled();
+}
+
 class TestPreviewsIOData : public PreviewsIOData {
  public:
   TestPreviewsIOData(
       const scoped_refptr<base::SingleThreadTaskRunner>& io_task_runner,
       const scoped_refptr<base::SingleThreadTaskRunner>& ui_task_runner)
       : PreviewsIOData(io_task_runner, ui_task_runner), initialized_(false) {}
   ~TestPreviewsIOData() override {}
 
   // Whether Initialize was called.
   bool initialized() { return initialized_; }
@@ skipping 68 matching lines @@
   std::unique_ptr<TestPreviewsIOData> io_data_;
   std::unique_ptr<PreviewsUIService> ui_service_;
 };
 
 }  // namespace
 
 TEST_F(PreviewsIODataTest, TestInitialization) {
   set_io_data(base::MakeUnique<TestPreviewsIOData>(loop_.task_runner(),
                                                    loop_.task_runner()));
   set_ui_service(base::MakeUnique<PreviewsUIService>(
-      io_data(), loop_.task_runner(), nullptr));
+      io_data(), loop_.task_runner(), nullptr, PreviewsIsEnabledCallback()));
   base::RunLoop().RunUntilIdle();
   // After the outstanding posted tasks have run, |io_data_| should be fully
   // initialized.
   EXPECT_TRUE(io_data()->initialized());
 }
 
 TEST_F(PreviewsIODataTest, TestShouldAllowPreview) {
   // Test most reasons to disallow the blacklist.
   // Excluded values are USER_RECENTLY_OPTED_OUT, USER_BLACKLISTED,
   // HOST_BLACKLISTED. These are internal to the blacklist.
   net::TestURLRequestContext context;
   GURL test_host("http://www.test_host.com");
   std::unique_ptr<net::URLRequest> request =
       context.CreateRequest(test_host, net::DEFAULT_PRIORITY, nullptr);
   set_io_data(base::MakeUnique<TestPreviewsIOData>(loop_.task_runner(),
                                                    loop_.task_runner()));
   base::HistogramTester histogram_tester;
 
-  // If not in the field trial, don't log anything, and return false.
-  EXPECT_FALSE(io_data()->ShouldAllowPreview(*request, PreviewsType::OFFLINE));
-  histogram_tester.ExpectTotalCount("Previews.EligibilityReason.Offline", 0);
-
-  // Enable Offline previews field trial.
-  base::FieldTrialList field_trial_list(nullptr);
-  std::map<std::string, std::string> params;
-  params["show_offline_pages"] = "true";
-  variations::AssociateVariationParams("ClientSidePreviews", "Enabled", params);
-  base::FieldTrialList::CreateFieldTrial("ClientSidePreviews", "Enabled");
-
   // The blacklist is not created yet.
   EXPECT_FALSE(io_data()->ShouldAllowPreview(*request, PreviewsType::OFFLINE));
   histogram_tester.ExpectUniqueSample(
       "Previews.EligibilityReason.Offline",
       static_cast<int>(PreviewsEligibilityReason::BLACKLIST_UNAVAILABLE), 1);
 
-  set_ui_service(base::WrapUnique(
-      new PreviewsUIService(io_data(), loop_.task_runner(),
-                            base::MakeUnique<TestPreviewsOptOutStore>())));
+  set_ui_service(base::MakeUnique<PreviewsUIService>(
+      io_data(), loop_.task_runner(),
+      base::MakeUnique<TestPreviewsOptOutStore>(),
+      base::Bind(&CheckOfflineFieldTrial)));

[tbansal1, 2017/03/10 23:06:23]

why can we not pass previews::params::IsOfflinePreviewsEnabled() directly?

[RyanSturm, 2017/03/13 21:12:47]

Type mismatch (takes a PreviewsType parameter)

+
+  // The blacklist is not created yet.
+  EXPECT_FALSE(io_data()->ShouldAllowPreview(*request, PreviewsType::OFFLINE));
+  histogram_tester.ExpectBucketCount(
+      "Previews.EligibilityReason.Offline",
+      static_cast<int>(PreviewsEligibilityReason::BLACKLIST_UNAVAILABLE), 2);
 
   base::RunLoop().RunUntilIdle();
 
+  histogram_tester.ExpectTotalCount("Previews.EligibilityReason.Offline", 2);
+  // If not in the field trial, don't log anything, and return false.
+  EXPECT_FALSE(io_data()->ShouldAllowPreview(*request, PreviewsType::OFFLINE));
+  histogram_tester.ExpectTotalCount("Previews.EligibilityReason.Offline", 2);
+
+  // Enable Offline previews field trial.
+  base::FieldTrialList field_trial_list(nullptr);
+  std::map<std::string, std::string> params;
+  params["show_offline_pages"] = "true";
+
+  variations::AssociateVariationParams("ClientSidePreviews", "Enabled", params);
+  base::FieldTrialList::CreateFieldTrial("ClientSidePreviews", "Enabled");
+
   // Return one of the failing statuses from the blacklist; cause the blacklist
   // to not be loaded by clearing the blacklist.
   base::Time now = base::Time::Now();
   io_data()->ClearBlackList(now, now);
 
   EXPECT_FALSE(io_data()->ShouldAllowPreview(*request, PreviewsType::OFFLINE));
   histogram_tester.ExpectBucketCount(
       "Previews.EligibilityReason.Offline",
       static_cast<int>(PreviewsEligibilityReason::BLACKLIST_DATA_NOT_LOADED),
       1);
@@ skipping 40 matching lines @@
       static_cast<int>(
           PreviewsEligibilityReason::RELOAD_DISALLOWED_FOR_OFFLINE),
       1);
 
   request->SetLoadFlags(0);
   EXPECT_TRUE(io_data()->ShouldAllowPreview(*request, PreviewsType::OFFLINE));
   histogram_tester.ExpectBucketCount(
       "Previews.EligibilityReason.Offline",
       static_cast<int>(PreviewsEligibilityReason::ALLOWED), 1);
 
-  histogram_tester.ExpectTotalCount("Previews.EligibilityReason.Offline", 7);
+  histogram_tester.ExpectTotalCount("Previews.EligibilityReason.Offline", 8);
 
   variations::testing::ClearAllVariationParams();
 }
 
 }  // namespace previews