Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: third_party/WebKit/Source/core/frame/FrameHost.h

Issue 2739033003: Move FrameHost::m_subframeCount to Page (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameHost.h
diff --git a/third_party/WebKit/Source/core/frame/FrameHost.h b/third_party/WebKit/Source/core/frame/FrameHost.h
index cdefcf1493b4136f5de664facf4f91556822efd6..91f33e50277aa5cc5220d4afa53f2a6fc8c195fc 100644
--- a/third_party/WebKit/Source/core/frame/FrameHost.h
+++ b/third_party/WebKit/Source/core/frame/FrameHost.h
@@ -88,16 +88,8 @@ class CORE_EXPORT FrameHost final
DECLARE_TRACE();
- // Don't allow more than a certain number of frames in a page.
- // This seems like a reasonable upper bound, and otherwise mutually
- // recursive frameset pages can quickly bring the program to its knees
- // with exponential growth in the number of frames.
- static const int maxNumberOfFrames = 1000;
- void incrementSubframeCount() { ++m_subframeCount; }
- void decrementSubframeCount() {
- ASSERT(m_subframeCount);
- --m_subframeCount;
- }
+ void incrementSubframeCount();
+ void decrementSubframeCount();
int subframeCount() const;
private:
@@ -112,7 +104,6 @@ class CORE_EXPORT FrameHost final
m_globalRootScrollerController;
AtomicString m_overrideEncoding;
- int m_subframeCount;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698