Issue 2739004: Add a category 1 suppression for a leak in FcFontSort().

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2739004: Add a category 1 suppression for a leak in FcFontSort(). (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 11 months ago by Robert Sesek

Modified:
4 years ago

Reviewers:
Evan Martin

CC:
chromium-reviews

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Add a category 1 suppression for a leak in FcFontSort(). BUG=46177 TEST=CrOs Valgrind 3 goes green. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49297

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : Harder bottom frame #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	tools/valgrind/memcheck/suppressions.txt	View	1 2	1 chunk	+12 lines, -0 lines	0 comments	Download

Trybot results:

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

I worry this will obfuscate anyone who leaks the return value of FcFontSort, but LGTM

4 years, 11 months ago (2010-06-09 18:42:34 UTC) #2

Robert Sesek

4 years, 11 months ago (2010-06-09 18:44:57 UTC) #3

On 2010/06/09 18:42:34, Evan Martin wrote:
> I worry this will obfuscate anyone who leaks the return value of FcFontSort,
but
> LGTM

Valid concern. I updated the suppression to hopefully make it a little stricter.
The problem is that one variant goes through calloc and the other goes through
realloc.

Expand Messages | Collapse Messages