Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2738983002: Sanity check that 'localhost' can be resolved before building Observatory (Closed)

Created:
3 years, 9 months ago by Cutch
Modified:
3 years, 9 months ago
Reviewers:
zra
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Sanity check that 'localhost' can be resolved before building Observatory BUG= R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/bffe527cfebbbf03fa519712d4a37bf587072eb9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M tools/observatory_tool.py View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Cutch
3 years, 9 months ago (2017-03-08 23:04:42 UTC) #3
zra
lgtm
3 years, 9 months ago (2017-03-08 23:43:49 UTC) #4
Cutch
3 years, 9 months ago (2017-03-08 23:46:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bffe527cfebbbf03fa519712d4a37bf587072eb9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698