Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: third_party/libjingle_xmpp/xmpp/xmpplogintask_unittest.cc

Issue 2738973004: Replace rtc::CryptString with std::string (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/libjingle_xmpp/xmpp/xmpplogintask_unittest.cc
diff --git a/third_party/libjingle_xmpp/xmpp/xmpplogintask_unittest.cc b/third_party/libjingle_xmpp/xmpp/xmpplogintask_unittest.cc
index 17bced53b754ee0ad9b32acd553d4283ba92dcfb..99bf934b22441dfaa873965594d48ca4d56c08f7 100644
--- a/third_party/libjingle_xmpp/xmpp/xmpplogintask_unittest.cc
+++ b/third_party/libjingle_xmpp/xmpp/xmpplogintask_unittest.cc
@@ -19,7 +19,6 @@
#include "third_party/libjingle_xmpp/xmpp/saslplainmechanism.h"
#include "third_party/libjingle_xmpp/xmpp/util_unittest.h"
#include "third_party/libjingle_xmpp/xmpp/xmppengine.h"
-#include "third_party/webrtc/base/cryptstring.h"
#include "third_party/webrtc/base/gunit.h"
#include "third_party/webrtc/typedefs.h"
@@ -52,14 +51,13 @@ class XmppLoginTaskTest : public testing::Test {
handler_.reset(new XmppTestHandler(engine_.get()));
Jid jid("david@my-server");
- rtc::InsecureCryptStringImpl pass;
- pass.password() = "david";
+ std::string pass("david");
engine_->SetSessionHandler(handler_.get());
engine_->SetOutputHandler(handler_.get());
engine_->AddStanzaHandler(handler_.get());
engine_->SetUser(jid);
engine_->SetSaslHandler(
- new buzz::PlainSaslHandler(jid, rtc::CryptString(pass), true));
+ new buzz::PlainSaslHandler(jid, pass, true));
}
virtual void TearDown() {
handler_.reset();

Powered by Google App Engine
This is Rietveld 408576698