Issue 2738963002: DateTime and Duration tweaks for better dart2js codegen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2738963002: DateTime and Duration tweaks for better dart2js codegen (Closed)

Created:
3 years, 9 months ago by sra1

Modified:
3 years, 9 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

DateTime and Duration tweaks for better dart2js codegen Changes help dart2js infer that DateTime._value is never null, leading to better code for the numerous compareTo calls in some apps. BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/a3571dc7c1d8cbc0f6971ad7fd2b6bac1d00d0b6

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	sdk/lib/_internal/js_runtime/lib/core_patch.dart	View		2 chunks	+3 lines, -2 lines	0 comments	Download
	M	sdk/lib/core/duration.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 5 (3 generated)

sra1

3 years, 9 months ago (2017-03-09 00:39:11 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a3571dc7c1d8cbc0f6971ad7fd2b6bac1d00d0b6 (presubmit successful).