Chromium Code Reviews Chromium Code Reviews
Issue 273893002:
New Layout Test to verify 'float' and 'clear' don't affect grid's items. (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html |
| diff --git a/LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html b/LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..d90938cbdb588a38d25ec323c99f23e1f3ac6c40 |
| --- /dev/null |
| +++ b/LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html |
| @@ -0,0 +1,27 @@ |
| +<!DOCTYPE html> |
| +<html> |
|
ojan
2014/05/21 18:40:57
We usually leave out the <html><head> and <body> e
jfernandez
2014/05/22 15:16:52
Done, even that most of the files in the css-grid-
|
| +<link href="resources/grid.css" rel="stylesheet"> |
| +<head> |
| +<style> |
| +.grid { |
| + background-color:grey; |
| +} |
| +.gridItem { |
|
ojan
2014/05/21 18:40:57
It'd be good to give each grid item a different ba
jfernandez
2014/05/22 15:16:52
Actually, the "firstRowSecondColumn" and related s
|
| + width: 50px; |
| + height: 50px; |
| +} |
| +</style> |
| +</head> |
| +<body> |
| +<div>This test checks that the grid's items are not affected by the 'float' and 'clear' properties.</div> |
| +<div class="grid"> |
| + <div style="float: right;" class="gridItem firstRowFirstColumn"></div> |
|
ojan
2014/05/21 18:40:57
Why are there 6 divs here and only 4 in the expect
jfernandez
2014/05/22 15:16:52
Done.
ojan
2014/05/23 02:13:36
I'm still confused by this. Do some of the divs ob
jfernandez
2014/05/23 14:57:06
I understand what you mean and I agree; it's confu
|
| + <div class="gridItem firstRowFirstColumn"></div> |
| + <div style="float: left;" class="gridItem firstRowSecondColumn"></div> |
| + <div style="float: right;" class="gridItem secondRowFirstColumn"></div> |
| + <div style="clear: right;" class="gridItem secondRowFirstColumn"></div> |
| + <div style="float: left;" class="gridItem secondRowSecondColumn"></div> |
| +</div> |
| +</body> |
| +</html> |
| + |
