third_party/WebKit/Source/core/svg/SVGTransform.cpp - Issue 2738863002: Replace ASSERT with DCHECK in core/svg/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGTransform.cpp

Issue 2738863002: Replace ASSERT with DCHECK in core/svg/ (Closed)

Patch Set: Split DCHECKS wherever possible Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGTransform.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGTransform.cpp b/third_party/WebKit/Source/core/svg/SVGTransform.cpp

index 0518512768ffa8b4cae33ef550c6ca5434e0b7e6..faff3e00875a521b5d18940b5c6198112456a95e 100644

--- a/third_party/WebKit/Source/core/svg/SVGTransform.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGTransform.cpp

@@ -201,7 +201,7 @@ String SVGTransform::valueAsString() const {

arguments[argumentCount++] = m_angle;

break;

}

- ASSERT(argumentCount <= WTF_ARRAY_LENGTH(arguments));

+ DCHECK_LE(argumentCount, WTF_ARRAY_LENGTH(arguments));

StringBuilder builder;

builder.append(transformTypePrefixForParsing(m_transformType));