third_party/WebKit/Source/core/svg/SVGTests.cpp - Issue 2738863002: Replace ASSERT with DCHECK in core/svg/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGTests.cpp

Issue 2738863002: Replace ASSERT with DCHECK in core/svg/ (Closed)

Patch Set: Split DCHECKS wherever possible Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGTests.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGTests.cpp b/third_party/WebKit/Source/core/svg/SVGTests.cpp

index 77b882b51824abc451fbbf2c623bf257380bc504..92ff15e0e25e8758d289c67c2eb7fb8fbcdf42aa 100644

--- a/third_party/WebKit/Source/core/svg/SVGTests.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGTests.cpp

@@ -37,7 +37,7 @@ SVGTests::SVGTests(SVGElement* contextElement)

m_systemLanguage(

SVGStaticStringList::create(contextElement,

SVGNames::systemLanguageAttr)) {

- ASSERT(contextElement);

+ DCHECK(contextElement);

contextElement->addToPropertyMap(m_requiredFeatures);

contextElement->addToPropertyMap(m_requiredExtensions);