Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Unified Diff: third_party/WebKit/Source/core/svg/SVGSVGElement.cpp

Issue 2738863002: Replace ASSERT with DCHECK in core/svg/ (Closed)
Patch Set: Split DCHECKS wherever possible Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGSVGElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp b/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp
index eec5eb4625d4fd4ce95c32121b79cb9a1acc8b7d..d356db3fdfb27defa4113b62f379ab6dadbce4be 100644
--- a/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp
@@ -107,7 +107,7 @@ float SVGSVGElement::currentScale() const {
}
void SVGSVGElement::setCurrentScale(float scale) {
- ASSERT(std::isfinite(scale));
+ DCHECK(std::isfinite(scale));
if (!isConnected() || !isOutermostSVGSVGElement())
return;
@@ -122,7 +122,7 @@ class SVGCurrentTranslateTearOff : public SVGPointTearOff {
}
void commitChange() override {
- ASSERT(contextElement());
+ DCHECK(contextElement());
toSVGSVGElement(contextElement())->updateUserTransform();
}
@@ -319,7 +319,7 @@ bool SVGSVGElement::checkIntersectionOrEnclosure(
const FloatRect& rect,
GeometryMatchingMode mode) const {
LayoutObject* layoutObject = element.layoutObject();
- ASSERT(!layoutObject || layoutObject->style());
+ DCHECK(!layoutObject || layoutObject->style());
if (!layoutObject ||
layoutObject->style()->pointerEvents() == EPointerEvents::kNone)
return false;
@@ -394,7 +394,7 @@ StaticNodeList* SVGSVGElement::getEnclosureList(
bool SVGSVGElement::checkIntersection(SVGElement* element,
SVGRectTearOff* rect) const {
- ASSERT(element);
+ DCHECK(element);
document().updateStyleAndLayoutIgnorePendingStylesheets();
return checkIntersectionOrEnclosure(*element, rect->target()->value(),
@@ -403,7 +403,7 @@ bool SVGSVGElement::checkIntersection(SVGElement* element,
bool SVGSVGElement::checkEnclosure(SVGElement* element,
SVGRectTearOff* rect) const {
- ASSERT(element);
+ DCHECK(element);
document().updateStyleAndLayoutIgnorePendingStylesheets();
return checkIntersectionOrEnclosure(*element, rect->target()->value(),
@@ -535,7 +535,7 @@ float SVGSVGElement::getCurrentTime() const {
}
void SVGSVGElement::setCurrentTime(float seconds) {
- ASSERT(std::isfinite(seconds));
+ DCHECK(std::isfinite(seconds));
seconds = max(seconds, 0.0f);
m_timeContainer->setElapsed(seconds);
}
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGRectElement.cpp ('k') | third_party/WebKit/Source/core/svg/SVGStaticStringList.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698