third_party/WebKit/Source/core/svg/SVGParsingError.h - Issue 2738863002: Replace ASSERT with DCHECK in core/svg/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGParsingError.h

Issue 2738863002: Replace ASSERT with DCHECK in core/svg/ (Closed)

Patch Set: Split DCHECKS wherever possible Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGParsingError.h

diff --git a/third_party/WebKit/Source/core/svg/SVGParsingError.h b/third_party/WebKit/Source/core/svg/SVGParsingError.h

index b0f4a35959c31f745aaebf6cd6f88385c53349aa..4777d02266b0bf5a5e55e502eb8916214c12640f 100644

--- a/third_party/WebKit/Source/core/svg/SVGParsingError.h

+++ b/third_party/WebKit/Source/core/svg/SVGParsingError.h

@@ -68,7 +68,7 @@ class SVGParsingError {

SVGParsingError(SVGParseStatus status = SVGParseStatus::NoError,

size_t locus = 0)

: m_status(static_cast<unsigned>(status)), m_locus(checkLocus(locus)) {

- ASSERT(this->status() == status);

+ DCHECK_EQ(this->status(), status);

}

SVGParseStatus status() const {