third_party/WebKit/Source/core/svg/SVGFEMergeElement.cpp - Issue 2738863002: Replace ASSERT with DCHECK in core/svg/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGFEMergeElement.cpp

Issue 2738863002: Replace ASSERT with DCHECK in core/svg/ (Closed)

Patch Set: Split DCHECKS wherever possible Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGFEMergeElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGFEMergeElement.cpp b/third_party/WebKit/Source/core/svg/SVGFEMergeElement.cpp

index 3d6c13de298ca3c077f859a007ff5780ae8d5e50..af2e52686e27522de47df2cf6e7350d3300b1ea5 100644

--- a/third_party/WebKit/Source/core/svg/SVGFEMergeElement.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGFEMergeElement.cpp

@@ -41,7 +41,7 @@ FilterEffect* SVGFEMergeElement::build(SVGFilterBuilder* filterBuilder,

Traversal<SVGFEMergeNodeElement>::childrenOf(*this)) {

FilterEffect* mergeEffect = filterBuilder->getEffectById(

AtomicString(mergeNode.in1()->currentValue()->value()));

- ASSERT(mergeEffect);

+ DCHECK(mergeEffect);

mergeInputs.push_back(mergeEffect);

}

return effect;