Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp

Issue 2738863002: Replace ASSERT with DCHECK in core/svg/ (Closed)
Patch Set: Split DCHECKS wherever possible Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp b/third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp
index 1ccd419b4517b1fa1b94e96f8053f632f1cde6b4..c40de28775b766b18e2e82f57e27be61f2e01f5c 100644
--- a/third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp
@@ -64,8 +64,8 @@ bool SVGFEDiffuseLightingElement::setFilterEffectAttribute(
if (attrName == SVGNames::lighting_colorAttr) {
LayoutObject* layoutObject = this->layoutObject();
- ASSERT(layoutObject);
- ASSERT(layoutObject->style());
+ DCHECK(layoutObject);
+ DCHECK(layoutObject->style());
return diffuseLighting->setLightingColor(
layoutObject->style()->svgStyle().lightingColor());
}
@@ -80,9 +80,9 @@ bool SVGFEDiffuseLightingElement::setFilterEffectAttribute(
const_cast<LightSource*>(diffuseLighting->lightSource());
const SVGFELightElement* lightElement =
SVGFELightElement::findLightElement(*this);
- ASSERT(lightSource);
- ASSERT(lightElement);
- ASSERT(effect->getFilter());
+ DCHECK(lightSource);
+ DCHECK(lightElement);
+ DCHECK(effect->getFilter());
if (attrName == SVGNames::azimuthAttr)
return lightSource->setAzimuth(
@@ -144,13 +144,13 @@ FilterEffect* SVGFEDiffuseLightingElement::build(
Filter* filter) {
FilterEffect* input1 = filterBuilder->getEffectById(
AtomicString(m_in1->currentValue()->value()));
- ASSERT(input1);
+ DCHECK(input1);
LayoutObject* layoutObject = this->layoutObject();
if (!layoutObject)
return nullptr;
- ASSERT(layoutObject->style());
+ DCHECK(layoutObject->style());
Color color = layoutObject->style()->svgStyle().lightingColor();
const SVGFELightElement* lightNode =

Powered by Google App Engine
This is Rietveld 408576698