third_party/WebKit/Source/core/svg/SVGFECompositeElement.cpp - Issue 2738863002: Replace ASSERT with DCHECK in core/svg/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGFECompositeElement.cpp

Issue 2738863002: Replace ASSERT with DCHECK in core/svg/ (Closed)

Patch Set: Split DCHECKS wherever possible Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGFECompositeElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGFECompositeElement.cpp b/third_party/WebKit/Source/core/svg/SVGFECompositeElement.cpp

index 619a7b58f7d53c6d6705945cd7aaf8aeef006b24..c88f2155efd77e588ef9684e1e65e7a53f9152e7 100644

--- a/third_party/WebKit/Source/core/svg/SVGFECompositeElement.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGFECompositeElement.cpp

@@ -132,7 +132,8 @@ FilterEffect* SVGFECompositeElement::build(SVGFilterBuilder* filterBuilder,

AtomicString(m_in1->currentValue()->value()));

FilterEffect* input2 = filterBuilder->getEffectById(

AtomicString(m_in2->currentValue()->value()));

- ASSERT(input1 && input2);

+ DCHECK(input1);

+ DCHECK(input2);

FilterEffect* effect = FEComposite::create(

filter, m_svgOperator->currentValue()->enumValue(),