Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGFEGaussianBlurElement.cpp

Issue 2738863002: Replace ASSERT with DCHECK in core/svg/ (Closed)
Patch Set: Split DCHECKS wherever possible Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 return; 61 return;
62 } 62 }
63 63
64 SVGFilterPrimitiveStandardAttributes::svgAttributeChanged(attrName); 64 SVGFilterPrimitiveStandardAttributes::svgAttributeChanged(attrName);
65 } 65 }
66 66
67 FilterEffect* SVGFEGaussianBlurElement::build(SVGFilterBuilder* filterBuilder, 67 FilterEffect* SVGFEGaussianBlurElement::build(SVGFilterBuilder* filterBuilder,
68 Filter* filter) { 68 Filter* filter) {
69 FilterEffect* input1 = filterBuilder->getEffectById( 69 FilterEffect* input1 = filterBuilder->getEffectById(
70 AtomicString(m_in1->currentValue()->value())); 70 AtomicString(m_in1->currentValue()->value()));
71 ASSERT(input1); 71 DCHECK(input1);
72 72
73 // "A negative value or a value of zero disables the effect of the given 73 // "A negative value or a value of zero disables the effect of the given
74 // filter primitive (i.e., the result is the filter input image)." 74 // filter primitive (i.e., the result is the filter input image)."
75 // (https://drafts.fxtf.org/filters/#element-attrdef-fegaussianblur-stddeviati on) 75 // (https://drafts.fxtf.org/filters/#element-attrdef-fegaussianblur-stddeviati on)
76 // 76 //
77 // => Clamp to non-negative. 77 // => Clamp to non-negative.
78 float stdDevX = std::max(0.0f, stdDeviationX()->currentValue()->value()); 78 float stdDevX = std::max(0.0f, stdDeviationX()->currentValue()->value());
79 float stdDevY = std::max(0.0f, stdDeviationY()->currentValue()->value()); 79 float stdDevY = std::max(0.0f, stdDeviationY()->currentValue()->value());
80 FilterEffect* effect = FEGaussianBlur::create(filter, stdDevX, stdDevY); 80 FilterEffect* effect = FEGaussianBlur::create(filter, stdDevX, stdDevY);
81 effect->inputEffects().push_back(input1); 81 effect->inputEffects().push_back(input1);
82 return effect; 82 return effect;
83 } 83 }
84 84
85 } // namespace blink 85 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGFEFloodElement.cpp ('k') | third_party/WebKit/Source/core/svg/SVGFEMergeElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698