Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGFEFloodElement.cpp

Issue 2738863002: Replace ASSERT with DCHECK in core/svg/ (Closed)
Patch Set: Split DCHECKS wherever possible Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2007, 2008 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2007, 2008 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 19 matching lines...) Expand all
30 30
31 inline SVGFEFloodElement::SVGFEFloodElement(Document& document) 31 inline SVGFEFloodElement::SVGFEFloodElement(Document& document)
32 : SVGFilterPrimitiveStandardAttributes(SVGNames::feFloodTag, document) {} 32 : SVGFilterPrimitiveStandardAttributes(SVGNames::feFloodTag, document) {}
33 33
34 DEFINE_NODE_FACTORY(SVGFEFloodElement) 34 DEFINE_NODE_FACTORY(SVGFEFloodElement)
35 35
36 bool SVGFEFloodElement::setFilterEffectAttribute( 36 bool SVGFEFloodElement::setFilterEffectAttribute(
37 FilterEffect* effect, 37 FilterEffect* effect,
38 const QualifiedName& attrName) { 38 const QualifiedName& attrName) {
39 LayoutObject* layoutObject = this->layoutObject(); 39 LayoutObject* layoutObject = this->layoutObject();
40 ASSERT(layoutObject); 40 DCHECK(layoutObject);
41 const ComputedStyle& style = layoutObject->styleRef(); 41 const ComputedStyle& style = layoutObject->styleRef();
42 FEFlood* flood = static_cast<FEFlood*>(effect); 42 FEFlood* flood = static_cast<FEFlood*>(effect);
43 43
44 if (attrName == SVGNames::flood_colorAttr) 44 if (attrName == SVGNames::flood_colorAttr)
45 return flood->setFloodColor(style.svgStyle().floodColor()); 45 return flood->setFloodColor(style.svgStyle().floodColor());
46 if (attrName == SVGNames::flood_opacityAttr) 46 if (attrName == SVGNames::flood_opacityAttr)
47 return flood->setFloodOpacity(style.svgStyle().floodOpacity()); 47 return flood->setFloodOpacity(style.svgStyle().floodOpacity());
48 48
49 return SVGFilterPrimitiveStandardAttributes::setFilterEffectAttribute( 49 return SVGFilterPrimitiveStandardAttributes::setFilterEffectAttribute(
50 effect, attrName); 50 effect, attrName);
51 } 51 }
52 52
53 FilterEffect* SVGFEFloodElement::build(SVGFilterBuilder*, Filter* filter) { 53 FilterEffect* SVGFEFloodElement::build(SVGFilterBuilder*, Filter* filter) {
54 LayoutObject* layoutObject = this->layoutObject(); 54 LayoutObject* layoutObject = this->layoutObject();
55 if (!layoutObject) 55 if (!layoutObject)
56 return nullptr; 56 return nullptr;
57 57
58 ASSERT(layoutObject->style()); 58 DCHECK(layoutObject->style());
59 const SVGComputedStyle& svgStyle = layoutObject->style()->svgStyle(); 59 const SVGComputedStyle& svgStyle = layoutObject->style()->svgStyle();
60 60
61 Color color = svgStyle.floodColor(); 61 Color color = svgStyle.floodColor();
62 float opacity = svgStyle.floodOpacity(); 62 float opacity = svgStyle.floodOpacity();
63 63
64 return FEFlood::create(filter, color, opacity); 64 return FEFlood::create(filter, color, opacity);
65 } 65 }
66 66
67 } // namespace blink 67 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698