third_party/WebKit/Source/core/svg/SVGFEBlendElement.cpp - Issue 2738863002: Replace ASSERT with DCHECK in core/svg/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGFEBlendElement.cpp

Issue 2738863002: Replace ASSERT with DCHECK in core/svg/ (Closed)

Patch Set: Split DCHECKS wherever possible Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>	2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>

3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>	3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>

4 *	4 *

5 * This library is free software; you can redistribute it and/or	5 * This library is free software; you can redistribute it and/or

6 * modify it under the terms of the GNU Library General Public	6 * modify it under the terms of the GNU Library General Public

7 * License as published by the Free Software Foundation; either	7 * License as published by the Free Software Foundation; either

8 * version 2 of the License, or (at your option) any later version.	8 * version 2 of the License, or (at your option) any later version.

9 *	9 *

10 * This library is distributed in the hope that it will be useful,	10 * This library is distributed in the hope that it will be useful,

(...skipping 134 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
145	145

146 SVGFilterPrimitiveStandardAttributes::svgAttributeChanged(attrName);	146 SVGFilterPrimitiveStandardAttributes::svgAttributeChanged(attrName);

147 }	147 }

148	148

149 FilterEffect* SVGFEBlendElement::build(SVGFilterBuilder* filterBuilder,	149 FilterEffect* SVGFEBlendElement::build(SVGFilterBuilder* filterBuilder,

150 Filter* filter) {	150 Filter* filter) {

151 FilterEffect* input1 = filterBuilder->getEffectById(	151 FilterEffect* input1 = filterBuilder->getEffectById(

152 AtomicString(m_in1->currentValue()->value()));	152 AtomicString(m_in1->currentValue()->value()));

153 FilterEffect* input2 = filterBuilder->getEffectById(	153 FilterEffect* input2 = filterBuilder->getEffectById(

154 AtomicString(m_in2->currentValue()->value()));	154 AtomicString(m_in2->currentValue()->value()));

155 ASSERT(input1 && input2);	155 DCHECK(input1);

	156 DCHECK(input2);

156	157

157 FilterEffect* effect = FEBlend::create(	158 FilterEffect* effect = FEBlend::create(

158 filter, toWebBlendMode(m_mode->currentValue()->enumValue()));	159 filter, toWebBlendMode(m_mode->currentValue()->enumValue()));

159 FilterEffectVector& inputEffects = effect->inputEffects();	160 FilterEffectVector& inputEffects = effect->inputEffects();

160 inputEffects.reserveCapacity(2);	161 inputEffects.reserveCapacity(2);

161 inputEffects.push_back(input1);	162 inputEffects.push_back(input1);

162 inputEffects.push_back(input2);	163 inputEffects.push_back(input2);

163 return effect;	164 return effect;

164 }	165 }

165	166

166 } // namespace blink	167 } // namespace blink

OLD	NEW