Replace ASSERT with DCHECK in core/svg/

third_party/WebKit/Source/core/svg/SVGPolyElement.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 30 matching lines @@
 
 Path SVGPolyElement::asPathFromPoints() const {
   Path path;
 
   SVGPointList* pointsValue = points()->currentValue();
   if (pointsValue->isEmpty())
     return path;
 
   SVGPointList::ConstIterator it = pointsValue->begin();
   SVGPointList::ConstIterator itEnd = pointsValue->end();
-  ASSERT(it != itEnd);
+  DCHECK(it != itEnd);

[tkent, 2017/03/14 22:33:14]

Use DCHECK_NE if possible.

[mrunal, 2017/03/14 23:52:14]

It throws an error,
../../base/logging.h:659:3: error: no matching function for call to
'MakeCheckOpValueString'
  MakeCheckOpValueString(&ss, v1);
  ^~~~~~~~~~~~~~~~~~~~~~
../../base/logging.h:704:1: note: in instantiation of function template
specialization
'logging::MakeCheckOpString<blink::SVGListPropertyHelper<blink::SVGPointList,
blink::SVGPoint>::ConstIterator,
blink::SVGListPropertyHelper<blink::SVGPointList,
blink::SVGPoint>::ConstIterator>' requested here
DEFINE_CHECK_OP_IMPL(NE, !=)
^
../../base/logging.h:695:25: note: expanded from macro 'DEFINE_CHECK_OP_IMPL'
      return ::logging::MakeCheckOpString(v1, v2, names);                    \
                        ^
../../third_party/WebKit/Source/core/svg/SVGPolyElement.cpp:51:3: note: in
instantiation of function template specialization
'logging::CheckNEImpl<blink::SVGListPropertyHelper<blink::SVGPointList,
blink::SVGPoint>::ConstIterator,
blink::SVGListPropertyHelper<blink::SVGPointList,
blink::SVGPoint>::ConstIterator>' requested here
  DCHECK_NE(it, itEnd);
  ^
../../base/logging.h:900:31: note: expanded from macro 'DCHECK_NE'
#define DCHECK_NE(val1, val2) DCHECK_OP(NE, !=, val1, val2)
                              ^
../../base/logging.h:853:18: note: expanded from macro 'DCHECK_OP'
      ::logging::Check##name##Impl((val1), (val2),                     \
                 ^

   path.moveTo(it->value());
   ++it;
 
   for (; it != itEnd; ++it)
     path.addLineTo(it->value());
 
   return path;
 }
 
 void SVGPolyElement::svgAttributeChanged(const QualifiedName& attrName) {
   if (attrName == SVGNames::pointsAttr) {
     SVGElement::InvalidationGuard invalidationGuard(this);
 
     LayoutSVGShape* layoutObject = toLayoutSVGShape(this->layoutObject());
     if (!layoutObject)
       return;
 
     layoutObject->setNeedsShapeUpdate();
     markForLayoutAndParentResourceInvalidation(layoutObject);
     return;
   }
 
   SVGGeometryElement::svgAttributeChanged(attrName);
 }
 
 }  // namespace blink