Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 273883002: Always display the origin chip, even if it won't fit. (Closed)

Created:
6 years, 7 months ago by macourteau
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Always display the origin chip, even if it won't fit. BUG=369853 R=shess@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269425

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M chrome/browser/ui/cocoa/location_bar/origin_chip_decoration.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/origin_chip_decoration.mm View 1 2 chunks +12 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
macourteau
6 years, 7 months ago (2014-05-08 16:01:07 UTC) #1
Scott Hess - ex-Googler
lgtm
6 years, 7 months ago (2014-05-08 21:03:06 UTC) #2
macourteau
The CQ bit was checked by macourteau@chromium.org
6 years, 7 months ago (2014-05-08 21:03:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/macourteau@chromium.org/273883002/20001
6 years, 7 months ago (2014-05-08 21:07:40 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-09 22:00:35 UTC) #5
Message was sent while issue was closed.
Change committed as 269425

Powered by Google App Engine
This is Rietveld 408576698