Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp

Issue 2738823004: Replace createCrossThreadTask with crossThreadBind in webaudio (Closed)
Patch Set: RefPtr -> wrapPassRefPtr Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012, Google Inc. All rights reserved. 2 * Copyright (C) 2012, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND 13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND
14 * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
16 * ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE 16 * ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE
17 * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL 17 * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
18 * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR 18 * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
19 * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER 19 * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
20 * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT 20 * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
21 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY 21 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
22 * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH 22 * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
23 * DAMAGE. 23 * DAMAGE.
24 */ 24 */
25 25
26 #include "modules/webaudio/AudioScheduledSourceNode.h" 26 #include "modules/webaudio/AudioScheduledSourceNode.h"
27
28 #include <algorithm>
27 #include "bindings/core/v8/ExceptionState.h" 29 #include "bindings/core/v8/ExceptionState.h"
28 #include "core/dom/ExceptionCode.h" 30 #include "core/dom/ExceptionCode.h"
29 #include "core/dom/ExecutionContextTask.h"
30 #include "core/dom/TaskRunnerHelper.h" 31 #include "core/dom/TaskRunnerHelper.h"
31 #include "modules/EventModules.h" 32 #include "modules/EventModules.h"
32 #include "modules/webaudio/BaseAudioContext.h" 33 #include "modules/webaudio/BaseAudioContext.h"
34 #include "platform/CrossThreadFunctional.h"
33 #include "platform/audio/AudioUtilities.h" 35 #include "platform/audio/AudioUtilities.h"
34 #include "wtf/MathExtras.h" 36 #include "wtf/MathExtras.h"
35 #include <algorithm>
36 37
37 namespace blink { 38 namespace blink {
38 39
39 const double AudioScheduledSourceHandler::UnknownTime = -1; 40 const double AudioScheduledSourceHandler::UnknownTime = -1;
40 41
41 AudioScheduledSourceHandler::AudioScheduledSourceHandler(NodeType nodeType, 42 AudioScheduledSourceHandler::AudioScheduledSourceHandler(NodeType nodeType,
42 AudioNode& node, 43 AudioNode& node,
43 float sampleRate) 44 float sampleRate)
44 : AudioHandler(nodeType, node, sampleRate), 45 : AudioHandler(nodeType, node, sampleRate),
45 m_startTime(0), 46 m_startTime(0),
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
219 // Let the context dereference this AudioNode. 220 // Let the context dereference this AudioNode.
220 context()->notifySourceNodeFinishedProcessing(this); 221 context()->notifySourceNodeFinishedProcessing(this);
221 setPlaybackState(FINISHED_STATE); 222 setPlaybackState(FINISHED_STATE);
222 } 223 }
223 } 224 }
224 225
225 void AudioScheduledSourceHandler::finish() { 226 void AudioScheduledSourceHandler::finish() {
226 finishWithoutOnEnded(); 227 finishWithoutOnEnded();
227 228
228 if (context()->getExecutionContext()) { 229 if (context()->getExecutionContext()) {
229 context()->getExecutionContext()->postTask( 230 TaskRunnerHelper::get(TaskType::MediaElementEvent,
230 TaskType::MediaElementEvent, BLINK_FROM_HERE, 231 context()->getExecutionContext())
231 createCrossThreadTask(&AudioScheduledSourceHandler::notifyEnded, 232 ->postTask(BLINK_FROM_HERE,
232 PassRefPtr<AudioScheduledSourceHandler>(this))); 233 crossThreadBind(&AudioScheduledSourceHandler::notifyEnded,
234 wrapPassRefPtr(this)));
233 } 235 }
234 } 236 }
235 237
236 void AudioScheduledSourceHandler::notifyEnded() { 238 void AudioScheduledSourceHandler::notifyEnded() {
237 DCHECK(isMainThread()); 239 DCHECK(isMainThread());
238 if (node()) 240 if (node())
239 node()->dispatchEvent(Event::create(EventTypeNames::ended)); 241 node()->dispatchEvent(Event::create(EventTypeNames::ended));
240 } 242 }
241 243
242 // ---------------------------------------------------------------- 244 // ----------------------------------------------------------------
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
280 // playback state if the context is closed. 282 // playback state if the context is closed.
281 if (context()->isContextClosed()) 283 if (context()->isContextClosed())
282 return false; 284 return false;
283 285
284 // If a node is scheduled or playing, do not collect the node prematurely 286 // If a node is scheduled or playing, do not collect the node prematurely
285 // even its reference is out of scope. Then fire onended event if assigned. 287 // even its reference is out of scope. Then fire onended event if assigned.
286 return audioScheduledSourceHandler().isPlayingOrScheduled(); 288 return audioScheduledSourceHandler().isPlayingOrScheduled();
287 } 289 }
288 290
289 } // namespace blink 291 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698