Replace createCrossThreadTask with crossThreadBind in webaudio

third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp

 /*
  * Copyright (C) 2012, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
  *    documentation and/or other materials provided with the distribution.
  *
  * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND
  * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
  * ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE
  * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
  * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
  * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
  * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
  * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
  * DAMAGE.
  */
 
 #include "modules/webaudio/AudioScheduledSourceNode.h"

[tzik, 2017/03/10 00:15:43]

Could you add a blank line after AudioScheduledSourceNode.h #include?

[yuryu, 2017/03/10 07:49:32]

Done.

+#include <algorithm>
 #include "bindings/core/v8/ExceptionState.h"
 #include "core/dom/ExceptionCode.h"
-#include "core/dom/ExecutionContextTask.h"
 #include "core/dom/TaskRunnerHelper.h"
 #include "modules/EventModules.h"
 #include "modules/webaudio/BaseAudioContext.h"
+#include "platform/CrossThreadFunctional.h"
 #include "platform/audio/AudioUtilities.h"
 #include "wtf/MathExtras.h"
-#include <algorithm>
 
 namespace blink {
 
 const double AudioScheduledSourceHandler::UnknownTime = -1;
 
 AudioScheduledSourceHandler::AudioScheduledSourceHandler(NodeType nodeType,
                                                          AudioNode& node,
                                                          float sampleRate)
     : AudioHandler(nodeType, node, sampleRate),
       m_startTime(0),
@@ skipping 173 matching lines @@
     // Let the context dereference this AudioNode.
     context()->notifySourceNodeFinishedProcessing(this);
     setPlaybackState(FINISHED_STATE);
   }
 }
 
 void AudioScheduledSourceHandler::finish() {
   finishWithoutOnEnded();
 
   if (context()->getExecutionContext()) {
-    context()->getExecutionContext()->postTask(
-        TaskType::MediaElementEvent, BLINK_FROM_HERE,
-        createCrossThreadTask(&AudioScheduledSourceHandler::notifyEnded,
-                              PassRefPtr<AudioScheduledSourceHandler>(this)));
+    TaskRunnerHelper::get(TaskType::MediaElementEvent,
+                          context()->getExecutionContext())
+        ->postTask(BLINK_FROM_HERE,
+                   crossThreadBind(&AudioScheduledSourceHandler::notifyEnded,
+                                   RefPtr<AudioScheduledSourceHandler>(this)));

[tzik, 2017/03/10 00:15:43]

Can we use wrapPassRefPtr here?

[yuryu, 2017/03/10 07:49:32]

Done.

   }
 }
 
 void AudioScheduledSourceHandler::notifyEnded() {
   DCHECK(isMainThread());
   if (node())
     node()->dispatchEvent(Event::create(EventTypeNames::ended));
 }
 
 // ----------------------------------------------------------------
@@ skipping 37 matching lines @@
   // playback state if the context is closed.
   if (context()->isContextClosed())
     return false;
 
   // If a node is scheduled or playing, do not collect the node prematurely
   // even its reference is out of scope. Then fire onended event if assigned.
   return audioScheduledSourceHandler().isPlayingOrScheduled();
 }
 
 }  // namespace blink