Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1452)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/pylintrc

Issue 2738823003: webkitpy: Slightly adjusting pylintrc allow names. (Closed)
Patch Set: Small fixes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/pylintrc
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/pylintrc b/third_party/WebKit/Tools/Scripts/webkitpy/pylintrc
index 2465b0f85b78e06c85d8d7b477fdaee32cec6c5b..b46e2bf6fa7faf6ae48df532a1653c0d75e59897 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/pylintrc
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/pylintrc
@@ -203,7 +203,15 @@ variable-rgx=[a-z_][a-z0-9_]{1,30}$
inlinevar-rgx=[A-Za-z_][A-Za-z0-9_]*$
# Good variable names which should always be accepted, separated by a comma.
-good-names=i,j,k,ex,Run,_,_log
+# These short names are acceptable in the following cases:
+# _ - unused value
+# i/j/k - for XXX in range():
+# k/v - for k, v in x.items():
+# x/y/z - coordinates
+# e - except XXXError as e:
+# f/fd - with open('blah') as f:
+# _log/Run - webkitpy functions
+good-names=_,i,j,k,v,x,y,z,e,f,fd,_log,Run
# Bad variable names which should always be refused, separated by a comma.
bad-names=foo,bar,baz,toto,tutu,tata
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698