Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2984)

Unified Diff: chrome/browser/prerender/prerender_histograms.h

Issue 2738783002: Prerender: Remove PerceivedPLT histograms (Closed)
Patch Set: remove PrerenderManager::RecordPerceivedPageLoadTime as well Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_histograms.h
diff --git a/chrome/browser/prerender/prerender_histograms.h b/chrome/browser/prerender/prerender_histograms.h
index e26cd195f9e9938dcacbffa4aace4f2e4cc71991..26945b7a3d2bb3dcd73bff417b46ec938ef724f5 100644
--- a/chrome/browser/prerender/prerender_histograms.h
+++ b/chrome/browser/prerender/prerender_histograms.h
@@ -40,14 +40,6 @@ class PrerenderHistograms {
// PrerenderManager.
PrerenderHistograms();
- // Records the perceived page load time for a page - effectively the time from
- // when the user navigates to a page to when it finishes loading. The actual
- // load may have started prior to navigation due to prerender hints.
- void RecordPerceivedPageLoadTime(Origin origin,
- base::TimeDelta perceived_page_load_time,
- NavigationType navigation_type,
- const GURL& url);
-
// Record that a first contentful paint occured, and whether we were able to
// successfuly record the perceived FCP.
void RecordPerceivedFirstContentfulPaintStatus(Origin origin,
@@ -59,12 +51,6 @@ class PrerenderHistograms {
// invalid and ignored.
void RecordPercentLoadDoneAtSwapin(Origin origin, double fraction) const;
- // Records the actual pageload time of a prerender that has not been swapped
- // in yet, but finished loading.
- void RecordPageLoadTimeNotSwappedIn(Origin origin,
- base::TimeDelta page_load_time,
- const GURL& url) const;
-
// Records the time from when a page starts prerendering to when the user
// navigates to it. This must be called on the UI thread.
void RecordTimeUntilUsed(Origin origin,
@@ -161,12 +147,6 @@ class PrerenderHistograms {
// from the point that we last saw a <link rel=prerender> tag.
base::TimeTicks last_prerender_seen_time_;
- // Indicates whether we have recorded page load events after the most
- // recent prerender. These must be initialized to true, so that we don't
- // start recording events before the first prerender occurs.
- bool seen_any_pageload_;
- bool seen_pageload_started_after_prerender_;
-
base::ThreadChecker thread_checker_;
DISALLOW_COPY_AND_ASSIGN(PrerenderHistograms);

Powered by Google App Engine
This is Rietveld 408576698