Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-placeholder-image-source.html

Issue 2738773004: No longer clamp setTimeout(..., 0) to 1ms. (Closed)
Patch Set: update webgl2 conformance expectations as well Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-placeholder-image-source.html
diff --git a/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-placeholder-image-source.html b/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-placeholder-image-source.html
index fa2b295fb74d1c7558c350df7838137e270c1a59..73d40a4007b0c0d84f345f6829af0fda92b47125 100644
--- a/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-placeholder-image-source.html
+++ b/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-placeholder-image-source.html
@@ -16,23 +16,24 @@ ctx.fillRect(0, 0, 100, 100);
ctx.commit();
verifyImage(canvas, [0, 0, 0, 0], "Verify that OffscreenCanvas.commit() does not propagate the image synchronously to the placeholder canvas.");
+// TODO(junov): Use the Promise returned by commit to schedule after the
+// commit. (crbug.com/709484)
setTimeout(function() {
- // setTimeout is a synchronization barrier that guarantees
- // that the offscreen commit has been processed by the event loop,
- // as long as the timeout event is queued after the call to commit().
- var green = [0, 255, 0, 255];
- verifyImage(canvas, green, "verify that drawImage works with placeholder canvas as a source.");
- var testImage = new Image();
- testImage.src = canvas.toDataURL();
- testImage.onload = function() {
- verifyImage(canvas, green, "verify that toDataURL works on placeholder canvas.");
- canvas.toBlob(blob => {
- createImageBitmap(blob).then(image => {
- verifyImage(image, green, "verify that toBlob works on placeholder canvas.");
- t.done();
- })
- });
- }
+ setTimeout(function() {
+ var green = [0, 255, 0, 255];
+ verifyImage(canvas, green, "verify that drawImage works with placeholder canvas as a source.");
+ var testImage = new Image();
+ testImage.src = canvas.toDataURL();
+ testImage.onload = function() {
+ verifyImage(canvas, green, "verify that toDataURL works on placeholder canvas.");
+ canvas.toBlob(blob => {
+ createImageBitmap(blob).then(image => {
+ verifyImage(image, green, "verify that toBlob works on placeholder canvas.");
+ t.done();
+ })
+ });
+ }
+ }, 0);
}, 0);
function verifyImage(image, expectedColor, description) {
@@ -45,4 +46,4 @@ function verifyImage(image, expectedColor, description) {
assert_array_equals(pixel, expectedColor, description);
});
}
-</script>
+</script>

Powered by Google App Engine
This is Rietveld 408576698